This repository was archived by the owner on Sep 27, 2022. It is now read-only.
feat: Do not collapse locations and activities options if there is only one group. #146
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you go through the Activity Finder wizard there are 2 steps with locations and activities. They are grouped into several collapsible fieldsets - and there are cases when you have just one group of options - then it doesn't make sense to make this group collapsible and it is better to show all the options right away.
Examples: https://ymcagbw.org/ymca-summer-camp-finder?step=selectLocations
https://ymcagbw.org/ymca-summer-camp-finder?step=selectActivities
https://ymcagbw.org/ymca-activity-finder?step=selectLocations
NB: requires artifacts rebuild.