Skip to content

Conversation

@antonshevelev
Copy link
Contributor

@antonshevelev antonshevelev commented Jul 14, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

Hi guys, it's me again)
Added Predis support for Yii2 stable version.
see #276

Had to skip a few flaky tests 3c81a0c

@samdark
Copy link
Member

samdark commented Jul 14, 2025

@antonshevelev awesome! Are these tests flaky for predis only? Let's use markTestSkipped() instead of returning false.

@antonshevelev
Copy link
Contributor Author

@antonshevelev awesome! Are these tests flaky for predis only? Let's use markTestSkipped() instead of returning false.

@samdark Nope, didn't write these tests for Predis - that's predis/predis's job. The flaky tests we're seeing are in yii2-redis itself.

@terabytesoftw
Copy link
Member

@antonshevelev awesome! Are these tests flaky for predis only? Let's use markTestSkipped() instead of returning false.

@samdark Nope, didn't write these tests for Predis - that's predis/predis's job. The flaky tests we're seeing are in yii2-redis itself.

That's right, tests sometimes fail and you have to re-run the CI. I actually tried to fix it once and couldn't.

@samdark samdark merged commit efe038d into yiisoft:master Jul 14, 2025
7 of 8 checks passed
@samdark
Copy link
Member

samdark commented Jul 14, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants