Skip to content

Optimize PNG files #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Optimize PNG files #4495

merged 1 commit into from
Nov 20, 2022

Conversation

dilyanpalauzov
Copy link
Contributor

by calling for i in $(find -name '*.png'); do optipng -o7 -zm9 $i; done.

by calling
  for i in `find -name '*.png'`; do optipng -o7 -zm9 $i; done
@what-the-diff
Copy link

what-the-diff bot commented Nov 18, 2022

  • The image files in the docs/guide/images folder were changed.
  • The images for jquery ui theme smoothness was updated to a newer version of jQuery UI (1.12).

@samdark samdark merged commit 991a162 into yiisoft:master Nov 20, 2022
@samdark
Copy link
Member

samdark commented Nov 20, 2022

Thanks.

@samdark samdark added this to the 1.1.27 milestone Nov 20, 2022
@marcovtwout
Copy link
Member

marcovtwout commented Nov 21, 2022

@dilyanpalauzov Could you tell me why we would not use the officially distributed files from jQueryUI and instead optimize these?

@samdark
Copy link
Member

samdark commented Nov 21, 2022

@marcovtwout just these are a bit smaller :) I did that in the past but it was lost during one of the updates.

@marcovtwout
Copy link
Member

@samdark Thanks for clearning that up. One might otherwise wonder why vendor files are modified / will give a binary signature mismatch. To save just a few hundred bytes I would personally use the originals, but if this was common practice before in yii1 I guess it makes sense.

@dilyanpalauzov
Copy link
Contributor Author

I optimized the PNG files in Limesurvey. Then I was told that once upstream synchronization happens, the changes will be reverted. In turn I optimized the PNG files used upstream projects, like here or jquery/jquery-ui#2132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants