Simplify error log (#113)

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>

Author: xepozz

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 3.2.2 under development
 
+- Enh #113: Simplify error log (@xepozz)
 - Enh #112: Add copy cURL button, sort request headers, fix UI (@xepozz)
 
 ## 3.2.1 March 07, 2024

src/ErrorHandler.php

@@ -62,7 +62,7 @@ public function handle(
         $renderer ??= $this->defaultRenderer;
 
         try {
-            $this->logger->error((string) (new PlainTextRenderer())->renderVerbose($t, $request), ['throwable' => $t]);
+            $this->logger->error(PlainTextRenderer::throwableToString($t), ['throwable' => $t]);
             return $this->debug ? $renderer->renderVerbose($t, $request) : $renderer->render($t, $request);
         } catch (Throwable $t) {
             return new ErrorData((string) $t);

src/Renderer/PlainTextRenderer.php

@@ -22,9 +22,26 @@ public function render(Throwable $t, ServerRequestInterface $request = null): Er
     public function renderVerbose(Throwable $t, ServerRequestInterface $request = null): ErrorData
     {
         return new ErrorData(
-            $t::class . " with message '{$t->getMessage()}' \n\nin "
-            . $t->getFile() . ':' . $t->getLine() . "\n\n"
-            . "Stack trace:\n" . $t->getTraceAsString()
+            self::throwableToString($t)
+        );
+    }
+
+    public static function throwableToString(Throwable $t): string
+    {
+        return sprintf(
+            <<<TEXT
+                %s with message "%s"
+
+                in %s:%s
+
+                Stack trace:
+                %s
+                TEXT,
+            $t::class,
+            $t->getMessage(),
+            $t->getFile(),
+            $t->getLine(),
+            $t->getTraceAsString()
         );
     }
 }

tests/Renderer/PlainTextRendererTest.php

@@ -22,12 +22,24 @@ public function testRenderVerbose(): void
     {
         $renderer = new PlainTextRenderer();
         $throwable = new RuntimeException();
-        $data = $renderer->renderVerbose($throwable);
-        $content = RuntimeException::class . " with message '{$throwable->getMessage()}' \n\nin "
-            . $throwable->getFile() . ':' . $throwable->getLine() . "\n\n"
-            . "Stack trace:\n" . $throwable->getTraceAsString()
-        ;
+        $expectedContent = sprintf(
+            <<<TEXT
+                %s with message "%s"
+
+                in %s:%s
 
-        $this->assertSame($content, (string) $data);
+                Stack trace:
+                %s
+                TEXT,
+            $throwable::class,
+            $throwable->getMessage(),
+            $throwable->getFile(),
+            $throwable->getLine(),
+            $throwable->getTraceAsString()
+        );
+
+        $data = $renderer->renderVerbose($throwable);
+        $this->assertSame($expectedContent, (string) $data);
+        $this->assertSame($expectedContent, PlainTextRenderer::throwableToString($throwable));
     }
 }