Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError in Activity class #714

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix AttributeError in Activity class #714

merged 1 commit into from
Sep 22, 2024

Conversation

Liudon
Copy link
Contributor

@Liudon Liudon commented Sep 21, 2024

When enable IGNORE_BEFORE_SAVING, workflow run failed:

Run python run_page/strava_sync.py *** *** ***
Traceback (most recent call last):
  File "/home/runner/work/workouts_page/workouts_page/run_page/strava_sync.py", line 33, in <module>
Access ok
    run_strava_sync(
  File "/home/runner/work/workouts_page/workouts_page/run_page/strava_sync.py", line 14, in run_strava_sync
    generator.sync(False)
  File "/home/runner/work/workouts_page/workouts_page/run_page/generator/__init__.py", line 68, in sync
    activity.summary_polyline = filter_out(activity.summary_polyline)
AttributeError: 'Activity' object has no attribute 'summary_polyline'
Start syncing
Error: Process completed with exit code 1.

Sorry, this is my first time using PR.
I accidentally submitted my own changes just now. I created a new branch to submit the modifications.
I appreciate it if you could review it again.

@vercel Vercel
Copy link

vercel bot commented Sep 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 2:37pm

@Liudon
Copy link
Contributor Author

Liudon commented Sep 21, 2024

@yihong0618 very very sorry, please review it again.

@yihong0618
Copy link
Owner

thanks will take a look tomorrow

yihong0618
yihong0618 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihong0618 yihong0618 merged commit fa3b736 into yihong0618:master Sep 22, 2024
10 checks passed
@Liudon Liudon deleted the dev branch September 22, 2024 06:11
ben-29 added a commit to ben-29/workouts_page that referenced this pull request Sep 29, 2024
@ben-29
Merge branch 'refs/heads/upstream' into feat-elevation-gain
4e16f44 
* refs/heads/upstream:
  feat: fix nrc Changed their apis (yihong0618#718)
  feat: conditionally output analysis JS only in Vercel environment (yihong0618#715)
  ignore the year which has no running data when drawing github.svg (yihong0618#712)
  Fix AttributeError in Activity class (yihong0618#714)
  doc: fix typo close yihong0618#704
  Some Front Optimization for Keep indoor data (yihong0618#709)
  Add new runner (yihong0618#707)
  feat: adding illustration for special tracks  (yihong0618#705)

# Conflicts:
#	run_page/generator/__init__.py
#	run_page/joyrun_sync.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihong0618 yihong0618 yihong0618 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liudon @yihong0618