Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use Tailwind CSS #655

Merged
merged 6 commits into from
Apr 15, 2024
Merged

style: use Tailwind CSS #655

merged 6 commits into from
Apr 15, 2024

Conversation

tianheg
Copy link
Collaborator

@tianheg tianheg commented Apr 14, 2024

Most of the work has been done, all that remains is to merge some module style files into className.

Suggestions for changes are welcome

Demo: https://running-page-fork-by-tianheg.vercel.app/


I found it difficult to merge conflicts, so create a new PR

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 11:54am

@yihong0618
Copy link
Owner

error image
image

* A nested style rule cannot start with 'thead' because it looks like the start of a declaration
* @import must precede all other statements
@tianheg
Copy link
Collaborator Author

tianheg commented Apr 14, 2024

The style is not right, I'm fixing it

@tianheg
Copy link
Collaborator Author

tianheg commented Apr 14, 2024

The style should be good now.

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, both laptop and mobile look good to me.

This will make it much easier to bootstrap the project. Compiling the sass is such a pain.

Copy link
Owner

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
amazing work

@yihong0618 yihong0618 merged commit 628c071 into yihong0618:master Apr 15, 2024
6 checks passed
ben-29 added a commit to ben-29/workouts_page that referenced this pull request Apr 21, 2024
* refs/heads/upstream:
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)

# Conflicts:
#	README-CN.md
#	README.md
#	pnpm-lock.yaml
#	src/components/Layout/style.module.scss
#	src/components/LocationStat/index.tsx
#	src/components/RunMap/index.tsx
#	src/components/RunMap/style.module.css
#	src/components/RunTable/RunRow.tsx
#	src/components/SVGStat/index.tsx
#	src/components/YearStat/index.tsx
#	src/styles/variables.scss
#	src/utils/const.ts
#	src/utils/utils.ts
chensoul added a commit to chensoul/running_page that referenced this pull request Apr 26, 2024
* yihong0618-master: (33 commits)
  Fix codoon and Upload tcx_to_garmin (yihong0618#662)
  Update README-CN.md (yihong0618#663)
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)
  chore: Update package manager and ignore requirements-dev.txt (yihong0618#632)
  add run.drink.cafe (yihong0618#628)
  feat: coros sync (yihong0618#623)
  Fix README typo (yihong0618#624)
  fix: ts type error (yihong0618#622)
  ...
ben-29 added a commit to ben-29/workouts_page that referenced this pull request May 26, 2024
* refs/heads/upstream: (71 commits)
  Add laqieer's running page to README (yihong0618#672)
  chore: add raycast extension support (yihong0618#670)
  add </details> (yihong0618#669)
  fix the deprecation warning (yihong0618#668)
  Fix codoon and Upload tcx_to_garmin (yihong0618#662)
  Update README-CN.md (yihong0618#663)
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)
  chore: Update package manager and ignore requirements-dev.txt (yihong0618#632)
  ...

# Conflicts:
#	run_page/gpxtrackposter/track.py
#	run_page/keep_sync.py
@tianheg tianheg deleted the tailwindcss branch June 11, 2024 00:57
Kugin pushed a commit to Kugin/running_page that referenced this pull request Sep 13, 2024
* style: use Tailwind CSS

* update yarn.lock

* fix style file path

* fix build error
* A nested style rule cannot start with 'thead' because it looks like the start of a declaration
* @import must precede all other statements

* fix style

* format files with prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants