fix: Fix parameter mismatch in EPUBBookLoaderHelper.translate_with_ba… #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckoff - Fix TypeError when calling translate_with_backoff with multiple arguments - Add proper parameter handling in the decorated method - Add jitter=None to prevent extra parameters from backoff decorator - Improve code readability and error handling
|
can you fix the lint? |
OK done! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
translate_with_backoffmethod inEPUBBookLoaderHelperclass was raising TypeError because of parameter mismatch between the method signature and actual calls through the backoff decorator.Error message:
TypeError: EPUBBookLoaderHelper.translate_with_backoff() takes 1 positional argument but 3 were given
Solution
Modified the method signature to properly handle parameters:
Improved error handling and logging
#bug