Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Return the success / failure of the close_handles() function. #3

Open
mrhappyasthma opened this issue Oct 11, 2022 · 1 comment
Open

[Feature request] Return the success / failure of the close_handles() function. #3

mrhappyasthma opened this issue Oct 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mrhappyasthma
Copy link
Contributor

This could return success/failure and optionally return the value of GetLastError - GetLastError.

Or, what might be nicer, would be to wrap the windows error codes in a python object/string/exception and surface that. So clients won't need to look up what error code int values mean. (https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes)
@yihleego yihleego added the enhancement New feature or request label Oct 11, 2022
@yihleego
Copy link
Owner

It looks good, but I have no time right now. Can you please make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrhappyasthma @yihleego