std::chrono::duration for timeout #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShirokovMikhail, thank you for the pull request. It looks very good. But it will break users' code, since the new API isn't compatible with the existing API... So I am not going to merge it to the master for now, but keep this pull request in mind for the future. Thank you very much for your contribution! |
|
How about keeping both API options? |
|
Honestly, I am satisfied with the existing API with no problem, even if I understand your suggestion is more elegant and modern. But, I'll ponder over your suggestion. |
yhirose
added a commit
that referenced
this pull request
Apr 2, 2021
|
@ShirokovMikhail, I actually implemented your suggestion to have both interfaces with minimal changes at #891. Does it satisfy your needs? |
|
@yhirose Great! Thanks a lot. |
yhirose
added a commit
that referenced
this pull request
Apr 2, 2021
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to use
cli.set_read_timeout(500ms);if using c++14