Skip to content

shield windows defines, in case they are already defined #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2017
Merged

shield windows defines, in case they are already defined #22

merged 1 commit into from
Nov 25, 2017

Conversation

ruby0x1
Copy link
Contributor

@ruby0x1 ruby0x1 commented Nov 22, 2017

If these are already defined (like via project settings or command line builds), trying to redefine these is an error.

This prevents that error and allows the code to be used there as well.

@yhirose yhirose merged commit ec34abb into yhirose:master Nov 25, 2017
@yhirose
Copy link
Owner

yhirose commented Nov 25, 2017

@underscorediscovery, thanks for the fix!

@ruby0x1 ruby0x1 deleted the fix-includes branch November 25, 2017 01:39
ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
shield windows defines, in case they are already defined
@315567599 315567599 mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants