Merge pull request #4 from cesfahani/bug/signed-unsigned-warning

yhirose · web-flow · commit 2c276ed31a02 · 2017-03-13T22:30:09.000-04:00
Fixed signed/unsigned comparison warning.
diff --git a/httplib.h b/httplib.h
@@ -173,14 +173,17 @@ inline int socket_read(socket_t sock, char* ptr, size_t size)
     return recv(sock, ptr, size, 0);
 }
 
-inline int socket_write(socket_t sock, const char* ptr, size_t size = -1)
+inline int socket_write(socket_t sock, const char* ptr, size_t size)
 {
-    if (size == -1) {
-        size = strlen(ptr);
-    }
     return send(sock, ptr, size, 0);
 }
 
+inline int socket_write(socket_t sock, const char* ptr)
+{
+    size_t size = strlen(ptr);
+    return socket_write(sock, ptr, size);
+}
+
 inline bool socket_gets(socket_t sock, char* buf, int bufsiz)
 {
     // TODO: buffering for better performance

Original file line number	Diff line number	Diff line change
`@@ -173,14 +173,17 @@ inline int socket_read(socket_t sock, char* ptr, size_t size)`
`173`	`173`	`return recv(sock, ptr, size, 0);`
`174`	`174`	`}`
`175`	`175`
`176`		`-inline int socket_write(socket_t sock, const char* ptr, size_t size = -1)`
	`176`	`+inline int socket_write(socket_t sock, const char* ptr, size_t size)`
`177`	`177`	`{`
`178`		`- if (size == -1) {`
`179`		`- size = strlen(ptr);`
`180`		`- }`
`181`	`178`	`return send(sock, ptr, size, 0);`
`182`	`179`	`}`
`183`	`180`
	`181`	`+inline int socket_write(socket_t sock, const char* ptr)`
	`182`	`+{`
	`183`	`+ size_t size = strlen(ptr);`
	`184`	`+ return socket_write(sock, ptr, size);`
	`185`	`+}`
	`186`	`+`
`184`	`187`	`inline bool socket_gets(socket_t sock, char* buf, int bufsiz)`
`185`	`188`	`{`
`186`	`189`	`// TODO: buffering for better performance`