Skip to content

v1.0.2 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2022
Merged

v1.0.2 #328

merged 4 commits into from
Nov 9, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Nov 8, 2022

Bug Fixes

@nmanu1 nmanu1 requested a review from a team as a code owner November 8, 2022 17:14
oshi97
oshi97 previously approved these changes Nov 8, 2022
@coveralls
Copy link

coveralls commented Nov 8, 2022

Coverage Status

Coverage remained the same at 85.454% when pulling 8a8bb38 on hotfix/v1.0.2 into 64ea8d7 on main.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Current unit coverage is 88.5823754789272%
Current visual coverage is 77.43315508021391%
Current combined coverage is 89.11877394636015%

Upgrade `ejs`, `async`, and `terser` in the test-site to address vulnerabilities in older versions of those packages.

J=none
TEST=none
Copy link
Contributor

@yen-tt yen-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as part of this fix, do you think we should update "@yext/analytics" dep to not be beta anymore?

Update the version of `@xmldom/xmldom` to address a vulnerability in Snyk. Regenerate the test-site package-lock to update some dependencies and remove other unnecessary dependencies from the top-level `search-ui-react` package.

J=SLAP-2423
TEST=none
Update the versions of `@xmldom/xmldom` and `loader-utils` to address Snyk vulnerabilities in the packages. Remove `babel-loader` from the package.json because it's no longer a peer dependency for `@storybook/addon-essentials` (as of v6.5.0).

J=none
TEST=none
Bump the package version to v1.0.2 and update the `search-headless-react` version to v2.0.1 to include the latest patch.
@nmanu1
Copy link
Contributor Author

nmanu1 commented Nov 8, 2022

as part of this fix, do you think we should update "@yext/analytics" dep to not be beta anymore?

nice catch, I'll update. Edit: since there were breaking changes between the beta version and v0.2.0+, we'll need to wait until a new major version of the component library to make this update.

@tmeyer2115 tmeyer2115 self-requested a review November 9, 2022 13:51
@nmanu1 nmanu1 merged commit 3976b59 into main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants