Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRS-72 lrs 1.2.10 #225

Merged
merged 9 commits into from
May 12, 2022
Merged

LRS-72 lrs 1.2.10 #225

merged 9 commits into from
May 12, 2022

Conversation

milt
Copy link
Member

@milt milt commented May 12, 2022

LRS-72 Handle deduplicated attachments introduced in yetanalytics/lrs#81

Additionally, deduplicates outbound attachments per guidance in the lrs README.

@milt milt marked this pull request as ready for review May 12, 2022 15:48
@milt milt requested a review from kelvinqian00 May 12, 2022 15:48
@milt
Copy link
Member Author

milt commented May 12, 2022

From an efficiency standpoint a future optimization might be to make a query that takes multiple statement IDs and returns unique attachments for the set, but it may be difficult to implement across all backends.

@kelvinqian00
Copy link
Collaborator

I'd love to see some tests for this. Given that there's two things added (handling deduped incoming attachments and deduping outbound attachments), these can probably be their own section in lrs_test.clj.

@milt
Copy link
Member Author

milt commented May 12, 2022

I'd love to see some tests for this. Given that there's two things added (handling deduped incoming attachments and deduping outbound attachments), these can probably be their own section in lrs_test.clj.

Where, in test-statement-fns or a separate one? That test is gnarly, the whole thing is stateful and adding a statement means you have to change half the other assertions.

@milt
Copy link
Member Author

milt commented May 12, 2022

Added tests in cf53077

@milt milt requested a review from kelvinqian00 May 12, 2022 20:21
@milt milt merged commit 0cc949f into main May 12, 2022
@milt milt deleted the LRS-72 branch May 12, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants