Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yalp Store stores unencrypted password in simple text file #9

Closed
teod0r opened this issue Jan 1, 2017 · 1 comment
Closed

Yalp Store stores unencrypted password in simple text file #9

teod0r opened this issue Jan 1, 2017 · 1 comment
Milestone

Comments

@teod0r
Copy link

teod0r commented Jan 1, 2017

Probably, it is not the best idea

@yeriomin
Copy link
Owner

Actually I don't know which password you mean.
The one in the tests is a placeholder in case other devs want to record more test responses.
The SharedPreferences storage is secure enough, unless you both root your phone and are careless with the stuff you grant privileges to. I also added a disclaimer telling user not to use their main account.

Either way, Yalp no longer stores user passwords at all. Password is used once to get auth token.

Fixed in master, will be in v0.3.
Thanks again for writing issues!

@yeriomin yeriomin added this to the v0.3 milestone Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants