Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

generator always includes bootstrap.js? #42

Closed
stream7 opened this issue Apr 3, 2013 · 8 comments
Closed

generator always includes bootstrap.js? #42

stream7 opened this issue Apr 3, 2013 · 8 comments

Comments

@stream7
Copy link

stream7 commented Apr 3, 2013

16:15 ~/Code/apps/web (yeoman) $ yo webapp

 _-----_
|       |
|--(o)--|   .--------------------------.

---------´ | Welcome to Yeoman, | ( _´U_ ) | ladies and gentlemen! |
/_A\ '__________________________'
| ~ |
**'.
**.'__
´ |° ´ Y

Out of the box I include HTML5 Boilerplate, jQuery and Modernizr.
Would you like to include Twitter Bootstrap for Sass? (Y/n) n
Would you like to include RequireJS (for AMD support)? (Y/n) y
create Gruntfile.js
create package.json
create .gitignore
create .gitattributes
create .bowerrc
create component.json
create .jshintrc
create .editorconfig
create app/favicon.ico
create app/404.html
create app/robots.txt
create app/.htaccess
create app/scripts/vendor/bootstrap.js
create app/styles/main.css
create app/scripts/app.js
create app/index.html
create app/scripts/main.js
create app/scripts/hello.coffee
invoke mocha:app
create test/index.html
create test/lib/chai.js
create test/lib/expect.js
create test/lib/mocha/mocha.css
create test/lib/mocha/mocha.js
create test/spec/test.js

I'm all done. Just run npm install && bower install to install the required dependencies.

As you see in the log it creates app/scripts/vendor/bootstrap.js
Why is that? Since I answered "No" to bootstrap sass I would expect to skip the js too.

@kevva
Copy link
Member

kevva commented Apr 7, 2013

@sindresorhus @passy, should we remove bootstrap js by default? I agree with @stream7 that this is kinda unexpected behaviour.

@sindresorhus
Copy link
Member

Yes from me, but it's @addyosmani or @paulirish that wanted it by default.

@passy
Copy link
Member

passy commented Apr 7, 2013

+1 for not shipping the file when disabled

@sindresorhus
Copy link
Member

ping @addyosmani @paulirish

@felquis
Copy link
Contributor

felquis commented Apr 23, 2013

Yes, It breaks my perfect workflow with yo webapp generator.

@addyosmani
Copy link
Member

I'm +1 on not shipping the file when disabled as well.

@kevva
Copy link
Member

kevva commented Apr 23, 2013

Okay, I'll remove it for now.

@paulirish
Copy link
Member

stick a knife in it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants