models: break out of loops (go-gitea#12159)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye · Jul 31, 2020 · c3fb904 · c3fb904
1 parent b06bdba
commit c3fb904
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/models/repo_sign.go b/models/repo_sign.go
@@ -103,12 +103,13 @@ func SignInitialCommit(repoPath string, u *User) (bool, string, error) {
 		return false, "", &ErrWontSign{noKey}
 	}
 
+Loop:
 	for _, rule := range rules {
 		switch rule {
 		case never:
 			return false, "", &ErrWontSign{never}
 		case always:
-			break
+			break Loop
 		case pubkey:
 			keys, err := ListGPGKeys(u.ID, ListOptions{})
 			if err != nil {
@@ -138,12 +139,13 @@ func (repo *Repository) SignWikiCommit(u *User) (bool, string, error) {
 		return false, "", &ErrWontSign{noKey}
 	}
 
+Loop:
 	for _, rule := range rules {
 		switch rule {
 		case never:
 			return false, "", &ErrWontSign{never}
 		case always:
-			break
+			break Loop
 		case pubkey:
 			keys, err := ListGPGKeys(u.ID, ListOptions{})
 			if err != nil {
@@ -190,12 +192,13 @@ func (repo *Repository) SignCRUDAction(u *User, tmpBasePath, parentCommit string
 		return false, "", &ErrWontSign{noKey}
 	}
 
+Loop:
 	for _, rule := range rules {
 		switch rule {
 		case never:
 			return false, "", &ErrWontSign{never}
 		case always:
-			break
+			break Loop
 		case pubkey:
 			keys, err := ListGPGKeys(u.ID, ListOptions{})
 			if err != nil {