#7: Support Kotlin data classes in StdReflector #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotlin support is enabled by default if you have kotlin-stdlib *AND* kotlin-reflection 1.9.x on your classpath. Note that you can use Kotlin data classes exposed as Java records (@JvmRecord) even if you have *NO* Kotlin dependencies on your classpath. Fixes: #7
lavrukov
approved these changes
Jan 26, 2024
| public final class StdReflector implements Reflector { | ||
| public static final Reflector instance = new StdReflector(List.of( | ||
| RecordType.FACTORY, | ||
| KotlinDataClassTypeFactory.instance, |
Contributor
There was a problem hiding this comment.
nitpick: instance is static, shoud we call it with UPPER_CASE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin support is enabled by default if you have
kotlin-stdlibANDkotlin-reflection1.9.x on your classpath.Note that you can use Kotlin data classes exposed as Java records (
@JvmRecord) even if you have NO Kotlin dependencies on your classpath.Fixes: #7