Skip to content

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Oct 2, 2024

Changelog entry

Improved connection loss handling in Change Data Capture.

Changelog category

  • Performance improvement

Additional information

...

@CyberROFL CyberROFL requested a review from snaury October 2, 2024 15:47
@CyberROFL CyberROFL self-assigned this Oct 2, 2024
@CyberROFL CyberROFL force-pushed the optimize-re-resolve branch from 880d8ae to 76e8d2d Compare October 2, 2024 15:55
@CyberROFL CyberROFL marked this pull request as ready for review October 2, 2024 15:56
Copy link

github-actions bot commented Oct 2, 2024

2024-10-02 15:59:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 42961d0 has started.
2024-10-02 15:59:25 UTC Artifacts will be uploaded here
2024-10-02 16:02:25 UTC ya make is running...
🔴 2024-10-02 16:08:33 UTC Build failed, see the logs.

Copy link

github-actions bot commented Oct 2, 2024

2024-10-02 15:59:47 UTC Pre-commit check linux-x86_64-release-asan for 42961d0 has started.
2024-10-02 15:59:57 UTC Artifacts will be uploaded here
2024-10-02 16:02:49 UTC ya make is running...
🔴 2024-10-02 16:12:42 UTC Build failed, see the logs.

@CyberROFL CyberROFL force-pushed the optimize-re-resolve branch from 76e8d2d to ea191a0 Compare October 2, 2024 16:45
@CyberROFL CyberROFL enabled auto-merge (squash) October 2, 2024 16:48
Copy link

github-actions bot commented Oct 2, 2024

2024-10-02 16:55:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5867a23 has started.
2024-10-02 16:55:56 UTC Artifacts will be uploaded here
2024-10-02 16:58:55 UTC ya make is running...
🟡 2024-10-02 17:46:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15235 13750 0 2 1377 106

2024-10-02 17:48:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-02 17:59:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 9 0 0 0 97

🟢 2024-10-02 17:59:42 UTC Build successful.
🟢 2024-10-02 18:00:01 UTC ydbd size 2.8 GiB changed* by -6.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 100fc57 merge: 5867a23 diff diff %
ydbd size 3 001 580 528 Bytes 3 001 573 920 Bytes -6.5 KiB -0.000%
ydbd stripped size 477 351 064 Bytes 477 349 336 Bytes -1.7 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 2, 2024

2024-10-02 16:56:42 UTC Pre-commit check linux-x86_64-release-asan for 5867a23 has started.
2024-10-02 16:56:53 UTC Artifacts will be uploaded here
2024-10-02 16:59:44 UTC ya make is running...
🟡 2024-10-02 18:40:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10497 10327 0 38 30 102

🟢 2024-10-02 18:41:27 UTC Build successful.
🟢 2024-10-02 18:41:56 UTC ydbd size 5.7 GiB changed* by -15.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 100fc57 merge: 5867a23 diff diff %
ydbd size 6 085 664 824 Bytes 6 085 649 000 Bytes -15.5 KiB -0.000%
ydbd stripped size 1 520 483 120 Bytes 1 520 478 416 Bytes -4.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from snaury October 2, 2024 17:17
@CyberROFL CyberROFL merged commit 91f8a44 into ydb-platform:main Oct 2, 2024
10 checks passed
@CyberROFL CyberROFL deleted the optimize-re-resolve branch October 3, 2024 08:59
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants