Skip to content

do not let faulty pdisks make group status dead in healthcheck #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Sep 25, 2024

Changelog entry

do not report group as dead based on pdisk status (when vdisk statuses are ok)

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Sep 25, 2024

2024-09-25 07:34:03 UTC Pre-commit check linux-x86_64-release-asan for ae1c339 has started.
2024-09-25 07:34:57 UTC Artifacts will be uploaded here
2024-09-25 07:38:40 UTC ya make is running...
🔴 2024-09-25 09:32:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10496 10280 0 46 47 123

🟢 2024-09-25 09:33:34 UTC Build successful.
🟢 2024-09-25 09:34:14 UTC ydbd size 5.7 GiB changed* by +160 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0cd4902 merge: ae1c339 diff diff %
ydbd size 6 080 642 568 Bytes 6 080 642 728 Bytes +160 Bytes +0.000%
ydbd stripped size 1 520 134 128 Bytes 1 520 134 192 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 25, 2024

2024-09-25 07:35:21 UTC Pre-commit check linux-x86_64-release-clang14 for ae1c339 has started.
2024-09-25 07:35:31 UTC Artifacts will be uploaded here
2024-09-25 07:38:27 UTC ya make is running...
🟢 2024-09-25 07:45:48 UTC Build successful.

Copy link

github-actions bot commented Sep 25, 2024

2024-09-25 07:35:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae1c339 has started.
2024-09-25 07:35:38 UTC Artifacts will be uploaded here
2024-09-25 07:38:33 UTC ya make is running...
🟡 2024-09-25 08:39:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15138 13483 0 5 1615 35

2024-09-25 08:40:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-25 08:52:03 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
284 (only retried tests) 187 0 0 7 90

🟢 2024-09-25 08:52:11 UTC Build successful.
🟢 2024-09-25 08:52:51 UTC ydbd size 8.5 GiB changed* by +992 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0cd4902 merge: ae1c339 diff diff %
ydbd size 9 073 833 832 Bytes 9 073 834 824 Bytes +992 Bytes +0.000%
ydbd stripped size 490 605 000 Bytes 490 605 064 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested review from adameat and ijon September 25, 2024 08:03
@vporyadke vporyadke self-assigned this Sep 25, 2024
@vporyadke vporyadke merged commit b8023f6 into ydb-platform:main Oct 16, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants