Skip to content

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Sep 24, 2024

Changelog entry

Add setting to configure min delay before node shutdown

Changelog category

  • New feature

Additional information

This setting is needed to make sure that clients forget about the node after its removal from discovery

@pixcc pixcc requested a review from CyberROFL September 24, 2024 09:44
@pixcc pixcc self-assigned this Sep 24, 2024
@github-actions
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:46:07 UTC Pre-commit check linux-x86_64-release-asan for 59a1088 has started.
2024-09-24 09:46:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:48:02 UTC Pre-commit check linux-x86_64-release-clang14 for 84ceeac has started.
2024-09-24 09:48:12 UTC Artifacts will be uploaded here
2024-09-24 09:51:30 UTC ya make is running...
🟢 2024-09-24 10:31:27 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:48:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 84ceeac has started.
2024-09-24 09:48:17 UTC Artifacts will be uploaded here
2024-09-24 09:51:42 UTC ya make is running...
🟡 2024-09-24 11:27:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41317 35749 0 4 5463 101

2024-09-24 11:30:51 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 11:42:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 21 0 0 0 90

🟢 2024-09-24 11:42:24 UTC Build successful.
🟢 2024-09-24 11:43:10 UTC ydbd size 8.4 GiB changed* by +8.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 922ce5c merge: 84ceeac diff diff %
ydbd size 9 071 190 256 Bytes 9 071 198 880 Bytes +8.4 KiB +0.000%
ydbd stripped size 490 550 600 Bytes 490 550 664 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:50:14 UTC Pre-commit check linux-x86_64-release-asan for 84ceeac has started.
2024-09-24 09:50:24 UTC Artifacts will be uploaded here
2024-09-24 09:53:39 UTC ya make is running...
🔴 2024-09-24 11:59:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11917 11726 0 34 38 119

🟢 2024-09-24 12:00:37 UTC Build successful.
🟢 2024-09-24 12:01:11 UTC ydbd size 5.7 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 922ce5c merge: 84ceeac diff diff %
ydbd size 6 079 178 392 Bytes 6 079 182 952 Bytes +4.5 KiB +0.000%
ydbd stripped size 1 519 930 128 Bytes 1 519 930 512 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc linked an issue Sep 24, 2024 that may be closed by this pull request
@pixcc pixcc force-pushed the delay-before-shutdown branch from d04a904 to 057743b Compare September 26, 2024 13:39
@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:41:39 UTC Pre-commit check linux-x86_64-release-clang14 for f10e6c3 has started.
2024-09-26 13:41:53 UTC Check cancelled

@pixcc pixcc changed the title Add delay before shutdown Add min delay before shutdown Sep 26, 2024
@pixcc pixcc requested a review from CyberROFL September 26, 2024 13:42
@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:45:41 UTC Pre-commit check linux-x86_64-release-clang14 for 8f8f260 has started.
2024-09-26 13:45:50 UTC Artifacts will be uploaded here
2024-09-26 13:49:00 UTC ya make is running...
2024-09-26 14:34:26 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:45:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8f8f260 has started.
2024-09-26 13:46:09 UTC Artifacts will be uploaded here
2024-09-26 13:49:15 UTC ya make is running...
2024-09-26 14:34:34 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:46:19 UTC Pre-commit check linux-x86_64-release-asan for 8f8f260 has started.
2024-09-26 13:46:29 UTC Artifacts will be uploaded here
2024-09-26 13:49:34 UTC ya make is running...
2024-09-26 14:34:31 UTC Check cancelled

@pixcc pixcc requested a review from CyberROFL September 26, 2024 14:37
@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 14:39:28 UTC Pre-commit check linux-x86_64-release-asan for 5816e52 has started.
2024-09-26 14:39:38 UTC Artifacts will be uploaded here
2024-09-26 14:42:44 UTC ya make is running...
🟡 2024-09-26 17:02:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11937 11742 0 31 41 123

🟢 2024-09-26 17:03:54 UTC Build successful.
🟢 2024-09-26 17:04:27 UTC ydbd size 5.7 GiB changed* by +34.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7d208c7 merge: 5816e52 diff diff %
ydbd size 6 084 945 760 Bytes 6 084 981 216 Bytes +34.6 KiB +0.001%
ydbd stripped size 1 520 889 744 Bytes 1 520 899 024 Bytes +9.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 14:39:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5816e52 has started.
2024-09-26 14:40:06 UTC Artifacts will be uploaded here
2024-09-26 14:43:13 UTC ya make is running...
🟡 2024-09-26 16:26:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41346 35443 0 10 5845 48

2024-09-26 16:30:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-26 16:41:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
449 (only retried tests) 351 0 0 7 91

🟢 2024-09-26 16:41:56 UTC Build successful.
🟢 2024-09-26 16:42:36 UTC ydbd size 8.5 GiB changed* by +49.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7d208c7 merge: 5816e52 diff diff %
ydbd size 9 081 561 320 Bytes 9 081 612 080 Bytes +49.6 KiB +0.001%
ydbd stripped size 490 872 840 Bytes 490 873 352 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc merged commit be4276e into ydb-platform:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable minimum waiting time before stopping the YDB process

2 participants