Pushdown some unary operators. #957
Conversation
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit bdd2383.
🔴 linux-x86_64-release-asan: some tests FAILED for commit bdd2383.
|
ydb/core/kqp/host/kqp_type_ann.cpp
Outdated
| if (!EnsureAtom(*op, ctx)) { | ||
| return false; | ||
| } | ||
| if (!op->IsAtom({"minus","abs","not","size","exists","empty"})) { |
There was a problem hiding this comment.
Usually with space between items:
{"minus", "abs", "not", "size", "exists", "empty"}
ydb/core/kqp/host/kqp_type_ann.cpp
Outdated
| if (!EnsureAtom(*op, ctx)) { | ||
| return false; | ||
| } | ||
| if (!op->IsAtom({"minus","abs","not","size","exists","empty"})) { |
There was a problem hiding this comment.
What is the difference between "not" here and TKqpOlapNot?
And the same question about TKqpOlapFilterExists?
There was a problem hiding this comment.
It's common replacement for these callables. I will not use them i future.
| } else if (IsSupportedArithmeticalExpression(node, settings)) { | ||
| TCoBinaryArithmetic op = node.Cast<TCoBinaryArithmetic>(); | ||
| return CheckExpressionNodeForPushdown(op.Left(), lambdaArg, settings) && CheckExpressionNodeForPushdown(op.Right(), lambdaArg, settings); | ||
| } else if (const auto op = node.Maybe<TCoUnaryArithmetic>(); op && settings.IsEnabled(TSettings::EFeatureFlag::ArithmeticalExpressions)) { |
There was a problem hiding this comment.
And where is tests for generic provider?
There was a problem hiding this comment.
ydb/core/kqp/ut/federated_query/generic
ydb/core/kqp/ut/federated_query/generic_ut
No description provided.