Skip to content

delete query from queryIndex if error during insert (#9231) #9495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

delete query from queryIndex if error during insert (#9231) #9495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ydb/core/kqp/compile_service/kqp_compile_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class TKqpQueryCache {
auto queryIt = QueryIndex.emplace(query, compileResult->Uid);
if (!queryIt.second) {
EraseByUid(compileResult->Uid);
QueryIndex.erase(query);
}
Y_ENSURE(queryIt.second);
}
Expand Down Expand Up @@ -782,6 +783,12 @@ class TKqpCompileService : public TActorBootstrapped<TKqpCompileService> {
auto query = request.Query ? *request.Query : *compileResult->Query;
if (compileResult) {
query.UserSid = compileResult->Query->UserSid;
if (query != *compileResult->Query) {
LOG_WARN_S(ctx, NKikimrServices::KQP_COMPILE_SERVICE, "queryId in recompile request and queryId in cache are different"
<< ", queryId in request: " << query.SerializeToString()
<< ", queryId in cache: " << compileResult->Query->SerializeToString()
);
}
}
TKqpCompileRequest compileRequest(ev->Sender, request.Uid, query,
compileSettings, request.UserToken, dbCounters, request.GUCSettings, request.ApplicationName,
Expand Down