Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

Changelog entry

There are many places where the field "remote_address" is empty. Fix this for these cases.

Changelog category

  • Bugfix

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner September 18, 2024 16:00
@github-actions
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 16:02:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 417bf97 has started.
2024-09-18 16:02:24 UTC Artifacts will be uploaded here
2024-09-18 16:05:38 UTC ya make is running...
🔴 2024-09-18 17:43:53 UTC Too many tests failed, NOT going to retry
🔴 2024-09-18 17:48:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41231 30315 0 5016 5669 231

🟢 2024-09-18 17:52:15 UTC Build successful.
🟡 2024-09-18 17:53:02 UTC ydbd size 8.4 GiB changed* by +232.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 51041e3 merge: 417bf97 diff diff %
ydbd size 9 038 173 976 Bytes 9 038 411 952 Bytes +232.4 KiB +0.003%
ydbd stripped size 489 038 664 Bytes 489 052 008 Bytes +13.0 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 16:02:19 UTC Pre-commit check linux-x86_64-release-asan for 417bf97 has started.
2024-09-18 16:02:29 UTC Artifacts will be uploaded here
2024-09-18 16:05:37 UTC ya make is running...
🔴 2024-09-18 17:58:21 UTC Too many tests failed, NOT going to retry
🔴 2024-09-18 18:01:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11851 8381 0 3225 45 200

🟢 2024-09-18 18:02:11 UTC Build successful.
🟡 2024-09-18 18:02:54 UTC ydbd size 5.6 GiB changed* by +311.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 51041e3 merge: 417bf97 diff diff %
ydbd size 6 053 958 328 Bytes 6 054 277 216 Bytes +311.4 KiB +0.005%
ydbd stripped size 1 514 567 856 Bytes 1 514 621 712 Bytes +52.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 16:02:24 UTC Pre-commit check linux-x86_64-release-clang14 for 417bf97 has started.
2024-09-18 16:02:34 UTC Artifacts will be uploaded here
2024-09-18 16:05:49 UTC ya make is running...
🟢 2024-09-18 16:50:26 UTC Build successful.

@adameat
Copy link
Member

adameat commented Sep 19, 2024

@UgnineSirdis FYI
#9420

@UgnineSirdis UgnineSirdis force-pushed the peer-name-in-audit-log branch from 5b50c30 to f9fffcf Compare October 6, 2024 10:59
@github-actions
Copy link

github-actions bot commented Oct 6, 2024

2024-10-06 11:01:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for f56656a has started.
2024-10-06 11:01:50 UTC Artifacts will be uploaded here
2024-10-06 11:04:52 UTC ya make is running...
🔴 2024-10-06 12:14:04 UTC Too many tests failed, NOT going to retry
🔴 2024-10-06 12:17:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41445 30672 0 5027 5458 288

🟢 2024-10-06 12:21:09 UTC Build successful.
🟡 2024-10-06 12:21:37 UTC ydbd size 2.8 GiB changed* by +137.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 791558d merge: f56656a diff diff %
ydbd size 3 002 254 016 Bytes 3 002 394 344 Bytes +137.0 KiB +0.005%
ydbd stripped size 477 417 912 Bytes 477 436 568 Bytes +18.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 6, 2024

2024-10-06 11:01:48 UTC Pre-commit check linux-x86_64-release-asan for f56656a has started.
2024-10-06 11:01:52 UTC Artifacts will be uploaded here
2024-10-06 11:04:57 UTC ya make is running...
🔴 2024-10-06 12:36:41 UTC Too many tests failed, NOT going to retry
🟡 2024-10-06 12:39:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11746 8212 0 3285 60 189

🟢 2024-10-06 12:40:22 UTC Build successful.
🟡 2024-10-06 12:41:00 UTC ydbd size 5.7 GiB changed* by +347.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 791558d merge: f56656a diff diff %
ydbd size 6 084 388 768 Bytes 6 084 744 056 Bytes +347.0 KiB +0.006%
ydbd stripped size 1 520 400 880 Bytes 1 520 465 648 Bytes +63.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 08:43:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 825732c has started.
2024-10-07 08:44:00 UTC Artifacts will be uploaded here
2024-10-07 08:47:14 UTC ya make is running...
🟢 2024-10-07 09:58:59 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41443 35886 0 0 5458 99

🟢 2024-10-07 10:02:29 UTC Build successful.
🟡 2024-10-07 10:02:47 UTC ydbd size 2.8 GiB changed* by +172.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bff272f merge: 825732c diff diff %
ydbd size 3 003 140 536 Bytes 3 003 316 776 Bytes +172.1 KiB +0.006%
ydbd stripped size 477 548 216 Bytes 477 568 856 Bytes +20.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 08:45:44 UTC Pre-commit check linux-x86_64-release-asan for 825732c has started.
2024-10-07 08:45:55 UTC Artifacts will be uploaded here
2024-10-07 08:49:04 UTC ya make is running...
2024-10-07 10:26:01 UTC Check cancelled

@UgnineSirdis UgnineSirdis force-pushed the peer-name-in-audit-log branch from 99b74d6 to 3d8e2d9 Compare October 7, 2024 10:25
@github-actions
Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 10:27:27 UTC Pre-commit check linux-x86_64-release-asan for 7f3fae2 has started.
2024-10-07 10:27:37 UTC Artifacts will be uploaded here
2024-10-07 10:30:40 UTC ya make is running...
🟡 2024-10-07 12:23:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11765 11488 0 96 71 110

🟢 2024-10-07 12:24:18 UTC Build successful.
🟡 2024-10-07 12:24:51 UTC ydbd size 5.7 GiB changed* by +338.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6361cf3 merge: 7f3fae2 diff diff %
ydbd size 6 084 062 752 Bytes 6 084 408 992 Bytes +338.1 KiB +0.006%
ydbd stripped size 1 519 811 472 Bytes 1 519 867 472 Bytes +54.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 10:29:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f3fae2 has started.
2024-10-07 10:30:01 UTC Artifacts will be uploaded here
2024-10-07 10:33:14 UTC ya make is running...
🟡 2024-10-07 11:51:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41446 35888 0 2 5459 97

2024-10-07 11:55:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-07 12:06:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 5 0 0 0 93

🟢 2024-10-07 12:06:24 UTC Build successful.
🟡 2024-10-07 12:06:43 UTC ydbd size 2.8 GiB changed* by +133.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6361cf3 merge: 7f3fae2 diff diff %
ydbd size 3 002 359 304 Bytes 3 002 495 608 Bytes +133.1 KiB +0.005%
ydbd stripped size 477 359 032 Bytes 477 373 592 Bytes +14.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon self-requested a review October 7, 2024 16:27
@UgnineSirdis UgnineSirdis merged commit e66ee0c into ydb-platform:main Oct 7, 2024
5 checks passed
@UgnineSirdis UgnineSirdis deleted the peer-name-in-audit-log branch October 31, 2024 11:43
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Nov 13, 2024
dcherednik pushed a commit to dcherednik/ydb that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants