Skip to content

fix addressing sparsed data #9399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix addressing sparsed data #9399

merged 3 commits into from
Sep 18, 2024

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Sep 17, 2024 •
edited
Loading

minor test fix
cherry-pick from main:

  • move ydb/core/formats into ydb/library/formats
  • fix addressing sparsed data

@zverevgeny zverevgeny linked an issue Sep 17, 2024 that may be closed by this pull request
CS fails on turning sparsed on on a column #9344
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 16:56:34 UTC Pre-commit check for 69e53b2 has started.
⚪ 2024-09-17 16:58:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-17 16:59:04 UTC Build successful.
⚪ 2024-09-17 16:59:26 UTC Tests are running...
🟢 2024-09-17 16:59:44 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4 4 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 16:56:36 UTC Pre-commit check for 69e53b2 has started.
⚪ 2024-09-17 16:58:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-17 16:59:13 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 16:56:39 UTC Pre-commit check for 69e53b2 has started.
⚪ 2024-09-17 16:58:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-17 16:59:21 UTC Build successful.
⚪ 2024-09-17 16:59:43 UTC Tests are running...
🟢 2024-09-17 17:00:05 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 5 0 0 0 0

GrigoriyPA and others added 2 commits September 17, 2024 17:00
@GrigoriyPA @zverevgeny
YQ-3671 move ydb/core/formats into ydb/library/formats (ydb-platform#…
69a5f4f 
…9180)

Conflicts:
	ydb/core/formats/arrow/common/container.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/checker.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/meta.cpp
@ivanmorozov333 @zverevgeny
Fix addressing sparsed (ydb-platform#9382)
efbd26a
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 17:13:38 UTC Pre-commit check for f2a7ac2 has started.
⚪ 2024-09-17 17:17:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-17 18:23:42 UTC Build successful.
🔴 2024-09-17 18:23:49 UTC Test run completed, no test results found for commit efbd26a. Please check test log.
🟡 2024-09-17 18:24:22 UTC ydbd size 8.2 GiB changed* by +967.4 KiB, which is >= 100.0 KiB vs stable-24-3-9-cs: Warning

ydbd size dash stable-24-3-9-cs: a20947f merge: f2a7ac2 diff diff %
ydbd size 8 795 858 368 Bytes 8 796 849 032 Bytes +967.4 KiB +0.011%
ydbd stripped size 479 901 832 Bytes 479 906 696 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 17:13:56 UTC Pre-commit check for f2a7ac2 has started.
⚪ 2024-09-17 17:17:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-17 18:00:38 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 17:14:43 UTC Pre-commit check for f2a7ac2 has started.
⚪ 2024-09-17 17:18:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-17 18:02:45 UTC Build successful.
⚪ 2024-09-17 18:03:00 UTC Tests are running...
🔴 2024-09-17 19:57:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11417 11335 0 12 27 43

🟡 2024-09-17 19:58:36 UTC ydbd size 5.5 GiB changed* by +413.5 KiB, which is >= 100.0 KiB vs stable-24-3-9-cs: Warning

ydbd size dash stable-24-3-9-cs: a20947f merge: f2a7ac2 diff diff %
ydbd size 5 957 296 552 Bytes 5 957 720 008 Bytes +413.5 KiB +0.007%
ydbd stripped size 1 491 545 056 Bytes 1 491 572 256 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Sep 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

⚪ 2024-09-18 04:18:45 UTC Pre-commit check for 2af7288 has started.
⚪ 2024-09-18 04:21:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-18 04:27:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

⚪ 2024-09-18 04:19:12 UTC Pre-commit check for 2af7288 has started.
⚪ 2024-09-18 04:22:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-18 04:45:00 UTC Build successful.
⚪ 2024-09-18 04:45:13 UTC Tests are running...
🔴 2024-09-18 06:41:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11416 11336 0 11 27 42

🟡 2024-09-18 06:42:34 UTC ydbd size 5.5 GiB changed* by +413.5 KiB, which is >= 100.0 KiB vs stable-24-3-9-cs: Warning

ydbd size dash stable-24-3-9-cs: a20947f merge: 2af7288 diff diff %
ydbd size 5 957 296 552 Bytes 5 957 720 008 Bytes +413.5 KiB +0.007%
ydbd stripped size 1 491 545 056 Bytes 1 491 572 256 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

⚪ 2024-09-18 04:21:16 UTC Pre-commit check for 2af7288 has started.
⚪ 2024-09-18 04:24:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-18 05:02:28 UTC Build successful.
⚪ 2024-09-18 05:02:44 UTC Tests are running...
🔴 2024-09-18 06:46:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39970 34709 0 5 5215 41

🟡 2024-09-18 06:47:51 UTC ydbd size 8.2 GiB changed* by +967.4 KiB, which is >= 100.0 KiB vs stable-24-3-9-cs: Warning

ydbd size dash stable-24-3-9-cs: a20947f merge: 2af7288 diff diff %
ydbd size 8 795 858 368 Bytes 8 796 849 032 Bytes +967.4 KiB +0.011%
ydbd stripped size 479 901 832 Bytes 479 906 696 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny marked this pull request as ready for review September 18, 2024 07:03
@zverevgeny zverevgeny requested a review from a team as a code owner September 18, 2024 07:03
@zverevgeny zverevgeny merged commit 602dfb0 into ydb-platform:stable-24-3-9-cs Sep 18, 2024
11 of 17 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Sep 20, 2024
@zverevgeny @GrigoriyPA @ivanmorozov333
fix addressing sparsed data (ydb-platform#9399)
1fb2d0f 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
Conflicts:
	.github/config/muted_ya.txt
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/checker.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/meta.cpp
fexolm pushed a commit to fexolm/ydb that referenced this pull request Sep 24, 2024
@zverevgeny @GrigoriyPA
@ivanmorozov333 @fexolm
fix addressing sparsed data (ydb-platform#9399)
1aae6f4 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
fexolm pushed a commit to fexolm/ydb that referenced this pull request Sep 24, 2024
@zverevgeny @GrigoriyPA
@ivanmorozov333 @fexolm
fix addressing sparsed data (ydb-platform#9399)
45a2b8f 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
fexolm pushed a commit to fexolm/ydb that referenced this pull request Sep 24, 2024
@zverevgeny @GrigoriyPA
@ivanmorozov333 @fexolm
fix addressing sparsed data (ydb-platform#9399)
a5915f7 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Oct 15, 2024
@zverevgeny @GrigoriyPA @ivanmorozov333
fix addressing sparsed data (ydb-platform#9399)
ff5e0f7 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
Conflicts:
	.github/config/muted_ya.txt
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/checker.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/meta.cpp
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Oct 15, 2024
@zverevgeny @GrigoriyPA @ivanmorozov333
fix addressing sparsed data (ydb-platform#9399)
5ea912e 
Co-authored-by: Pisarenko Grigoriy <79596613+GrigoriyPA@users.noreply.github.com>
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
Conflicts:
	.github/config/muted_ya.txt
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/checker.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/meta.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS fails on turning sparsed on on a column
3 participants
@zverevgeny @ivanmorozov333 @GrigoriyPA