Skip to content

24-3: NodeBroker: use deltas when returning recently added nodes #9161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Sep 12, 2024

Changelog entry

NodeBroker now sends deltas when listing recently added nodes.

Changelog category

  • Bugfix

Additional information

This fixes one of the issues where a blue-green deploy is stalled in big clusters due to cached node lists becoming invalidated with each new added node and excessive traffic when it is repeatedly resent to all nodes in the cluster. With a minor backwards compatible change to TEvListNodes it becomes possible to only send recently added nodes.

Related to #8942.

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 14:29:02 UTC Pre-commit check for 5b5cdce has started.
2024-09-12 14:32:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-12 14:54:42 UTC Build successful.
2024-09-12 14:54:56 UTC Tests are running...
🔴 2024-09-12 16:59:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11176 11090 0 26 26 34

🟢 2024-09-12 17:00:09 UTC ydbd size 5.5 GiB changed* by +45.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 65caa64 merge: 5b5cdce diff diff %
ydbd size 5 935 537 784 Bytes 5 935 584 304 Bytes +45.4 KiB +0.001%
ydbd stripped size 1 488 031 840 Bytes 1 488 039 072 Bytes +7.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 14:40:12 UTC Pre-commit check for 5b5cdce has started.
2024-09-12 14:42:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-12 14:48:55 UTC Build successful.

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 14:43:27 UTC Pre-commit check for 5b5cdce has started.
2024-09-12 14:46:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-12 15:25:41 UTC Build successful.
2024-09-12 15:25:57 UTC Tests are running...
🔴 2024-09-12 17:07:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39720 34473 0 5 5212 30

🟢 2024-09-12 17:08:23 UTC ydbd size 8.2 GiB changed* by +57.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 65caa64 merge: 5b5cdce diff diff %
ydbd size 8 762 160 560 Bytes 8 762 219 408 Bytes +57.5 KiB +0.001%
ydbd stripped size 479 043 784 Bytes 479 046 152 Bytes +2.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury self-assigned this Sep 12, 2024
@snaury snaury marked this pull request as ready for review September 13, 2024 08:08
@snaury snaury requested a review from a team as a code owner September 13, 2024 08:09
@snaury snaury enabled auto-merge (squash) September 27, 2024 08:12
@snaury snaury merged commit 622ee41 into ydb-platform:stable-24-3 Sep 27, 2024
8 of 12 checks passed
@snaury snaury deleted the feature-8942-add-node-deltas-24-3 branch September 27, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants