Skip to content

speed up logging exp #9087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 12, 2024
Merged

speed up logging exp #9087

merged 12 commits into from
Sep 12, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 12:40:03 UTC Pre-commit check linux-x86_64-release-clang14 for eb33c93 has started.
⚫ 2024-09-11 12:41:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 12:40:09 UTC Pre-commit check linux-x86_64-release-asan for eb33c93 has started.
⚪ 2024-09-11 12:40:26 UTC Artifacts will be uploaded here
⚫ 2024-09-11 12:41:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:01:36 UTC Pre-commit check linux-x86_64-release-asan for b1f606f has started.
⚪ 2024-09-11 13:01:56 UTC Artifacts will be uploaded here
⚪ 2024-09-11 13:04:54 UTC ya make is running...
⚫ 2024-09-11 14:23:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:07:29 UTC Pre-commit check linux-x86_64-release-clang14 for b1f606f has started.
⚪ 2024-09-11 13:07:46 UTC Artifacts will be uploaded here
⚪ 2024-09-11 13:10:42 UTC ya make is running...
🟢 2024-09-11 13:53:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:10:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for b1f606f has started.
⚪ 2024-09-11 13:11:35 UTC Artifacts will be uploaded here
⚪ 2024-09-11 13:15:08 UTC ya make is running...
⚫ 2024-09-11 14:23:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 14:25:31 UTC Pre-commit check linux-x86_64-release-asan for 78e10af has started.
⚪ 2024-09-11 14:25:41 UTC Artifacts will be uploaded here
⚪ 2024-09-11 14:28:40 UTC ya make is running...
⚫ 2024-09-11 15:42:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 14:26:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78e10af has started.
⚪ 2024-09-11 14:27:42 UTC Artifacts will be uploaded here
⚪ 2024-09-11 14:31:11 UTC ya make is running...
⚫ 2024-09-11 15:42:24 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 14:27:17 UTC Pre-commit check linux-x86_64-release-clang14 for 78e10af has started.
⚪ 2024-09-11 14:27:26 UTC Artifacts will be uploaded here
⚪ 2024-09-11 14:30:18 UTC ya make is running...
🟢 2024-09-11 15:06:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:43:37 UTC Pre-commit check linux-x86_64-release-clang14 for 36a4d60 has started.
⚪ 2024-09-11 15:43:58 UTC Artifacts will be uploaded here
⚫ 2024-09-11 15:45:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:45:09 UTC Pre-commit check linux-x86_64-release-asan for 36a4d60 has started.
⚪ 2024-09-11 15:45:19 UTC Artifacts will be uploaded here
⚫ 2024-09-11 15:45:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:45:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 36a4d60 has started.
⚪ 2024-09-11 15:45:29 UTC Artifacts will be uploaded here
⚫ 2024-09-11 15:45:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:47:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6bf9456 has started.
⚪ 2024-09-11 15:47:27 UTC Artifacts will be uploaded here
⚪ 2024-09-11 15:50:23 UTC ya make is running...
⚫ 2024-09-11 15:56:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:47:24 UTC Pre-commit check linux-x86_64-release-clang14 for 6bf9456 has started.
⚪ 2024-09-11 15:48:17 UTC Artifacts will be uploaded here
⚪ 2024-09-11 15:51:41 UTC ya make is running...
⚫ 2024-09-11 15:56:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:49:34 UTC Pre-commit check linux-x86_64-release-asan for 6bf9456 has started.
⚪ 2024-09-11 15:49:43 UTC Artifacts will be uploaded here
⚪ 2024-09-11 15:52:32 UTC ya make is running...
⚫ 2024-09-11 15:56:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:57:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 14ef366 has started.
⚪ 2024-09-11 15:57:11 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:00:09 UTC ya make is running...
⚫ 2024-09-11 16:25:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:57:44 UTC Pre-commit check linux-x86_64-release-asan for 14ef366 has started.
⚪ 2024-09-11 15:57:53 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:00:41 UTC ya make is running...
⚫ 2024-09-11 16:24:59 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 15:58:07 UTC Pre-commit check linux-x86_64-release-clang14 for 14ef366 has started.
⚪ 2024-09-11 15:58:14 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:01:01 UTC ya make is running...
🟢 2024-09-11 16:14:41 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:29:04 UTC Pre-commit check linux-x86_64-release-clang14 for ca6ae0f has started.
⚪ 2024-09-11 16:29:13 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:32:06 UTC ya make is running...
🟢 2024-09-11 16:37:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:29:12 UTC Pre-commit check linux-x86_64-release-asan for ca6ae0f has started.
⚪ 2024-09-11 16:29:21 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:32:10 UTC ya make is running...
⚫ 2024-09-11 16:41:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:29:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca6ae0f has started.
⚪ 2024-09-11 16:29:25 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:32:17 UTC ya make is running...
⚫ 2024-09-11 16:41:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:42:50 UTC Pre-commit check linux-x86_64-release-asan for d6e25a0 has started.
⚪ 2024-09-11 16:43:29 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:47:04 UTC ya make is running...
🔴 2024-09-11 18:17:38 UTC Too many tests failed, NOT going to retry
🔴 2024-09-11 18:18:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11772 11088 0 537 29 118

🟢 2024-09-11 18:19:52 UTC Build successful.
🟡 2024-09-11 18:20:28 UTC ydbd size 5.6 GiB changed* by +136.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5f125c0 merge: d6e25a0 diff diff %
ydbd size 6 041 294 496 Bytes 6 041 433 760 Bytes +136.0 KiB +0.002%
ydbd stripped size 1 511 717 968 Bytes 1 511 741 264 Bytes +22.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:43:04 UTC Pre-commit check linux-x86_64-release-clang14 for d6e25a0 has started.
⚪ 2024-09-11 16:43:13 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:46:09 UTC ya make is running...
🟢 2024-09-11 16:51:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 16:43:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for d6e25a0 has started.
⚪ 2024-09-11 16:44:16 UTC Artifacts will be uploaded here
⚪ 2024-09-11 16:47:52 UTC ya make is running...
🔴 2024-09-11 17:54:00 UTC Too many tests failed, NOT going to retry
🔴 2024-09-11 17:59:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41065 34816 0 529 5433 287

🟢 2024-09-11 18:03:10 UTC Build successful.
🟡 2024-09-11 18:03:47 UTC ydbd size 8.4 GiB changed* by +119.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5f125c0 merge: d6e25a0 diff diff %
ydbd size 9 029 719 008 Bytes 9 029 841 320 Bytes +119.4 KiB +0.001%
ydbd stripped size 487 854 440 Bytes 487 863 432 Bytes +8.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 05:06:29 UTC Pre-commit check linux-x86_64-release-clang14 for 4714c25 has started.
⚪ 2024-09-12 05:06:39 UTC Artifacts will be uploaded here
⚪ 2024-09-12 05:09:44 UTC ya make is running...
🟢 2024-09-12 05:21:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 05:06:35 UTC Pre-commit check linux-x86_64-release-asan for 4714c25 has started.
⚪ 2024-09-12 05:06:45 UTC Artifacts will be uploaded here
⚪ 2024-09-12 05:09:39 UTC ya make is running...
⚫ 2024-09-12 06:38:11 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 05:08:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4714c25 has started.
⚪ 2024-09-12 05:09:06 UTC Artifacts will be uploaded here
⚪ 2024-09-12 05:11:59 UTC ya make is running...
🟡 2024-09-12 06:27:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41084 35549 0 4 5438 93

⚪ 2024-09-12 06:31:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-12 06:38:41 UTC ydbd size 8.4 GiB changed* by +115.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9a9b2e6 merge: 4714c25 diff diff %
ydbd size 9 034 978 992 Bytes 9 035 097 256 Bytes +115.5 KiB +0.001%
ydbd stripped size 488 200 168 Bytes 488 205 064 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-09-12 06:38:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:41:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 27e79e8 has started.
⚪ 2024-09-12 06:42:06 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:44:57 UTC ya make is running...
⚫ 2024-09-12 06:46:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:42:00 UTC Pre-commit check linux-x86_64-release-asan for 27e79e8 has started.
⚪ 2024-09-12 06:42:11 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:45:07 UTC ya make is running...
⚫ 2024-09-12 06:46:11 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:42:14 UTC Pre-commit check linux-x86_64-release-clang14 for 27e79e8 has started.
⚪ 2024-09-12 06:42:24 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:45:25 UTC ya make is running...
⚫ 2024-09-12 06:46:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:49:17 UTC Pre-commit check linux-x86_64-release-asan for e21d19a has started.
⚪ 2024-09-12 06:49:28 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:52:24 UTC ya make is running...
⚫ 2024-09-12 07:08:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:49:21 UTC Pre-commit check linux-x86_64-release-clang14 for e21d19a has started.
⚪ 2024-09-12 06:49:31 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:52:38 UTC ya make is running...
🟢 2024-09-12 06:59:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 06:49:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for e21d19a has started.
⚪ 2024-09-12 06:49:49 UTC Artifacts will be uploaded here
⚪ 2024-09-12 06:52:50 UTC ya make is running...
⚫ 2024-09-12 07:08:05 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 07:10:10 UTC Pre-commit check linux-x86_64-release-asan for 6c1feb2 has started.
⚪ 2024-09-12 07:10:21 UTC Artifacts will be uploaded here
⚪ 2024-09-12 07:13:19 UTC ya make is running...
🔴 2024-09-12 08:51:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11777 11614 0 25 38 100

🟢 2024-09-12 08:52:38 UTC Build successful.
🟡 2024-09-12 08:53:10 UTC ydbd size 5.6 GiB changed* by +152.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 42b25d4 merge: 6c1feb2 diff diff %
ydbd size 6 044 822 040 Bytes 6 044 978 472 Bytes +152.8 KiB +0.003%
ydbd stripped size 1 512 777 904 Bytes 1 512 804 272 Bytes +25.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 07:12:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6c1feb2 has started.
⚪ 2024-09-12 07:12:21 UTC Artifacts will be uploaded here
⚪ 2024-09-12 07:15:14 UTC ya make is running...
🟡 2024-09-12 08:27:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41083 35340 0 12 5539 192

⚪ 2024-09-12 08:30:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-12 08:38:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
313 (only retried tests) 219 0 0 8 86

🟢 2024-09-12 08:38:17 UTC Build successful.
🟡 2024-09-12 08:38:59 UTC ydbd size 8.4 GiB changed* by +127.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 42b25d4 merge: 6c1feb2 diff diff %
ydbd size 9 034 978 992 Bytes 9 035 109 728 Bytes +127.7 KiB +0.001%
ydbd stripped size 488 200 168 Bytes 488 206 024 Bytes +5.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 07:12:23 UTC Pre-commit check linux-x86_64-release-clang14 for 6c1feb2 has started.
⚪ 2024-09-12 07:12:33 UTC Artifacts will be uploaded here
⚪ 2024-09-12 07:15:33 UTC ya make is running...
🟢 2024-09-12 07:25:35 UTC Build successful.

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 12, 2024 09:11
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner September 12, 2024 09:11
@ivanmorozov333 ivanmorozov333 merged commit 658b27b into ydb-platform:main Sep 12, 2024
10 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_logging_exp branch September 12, 2024 09:11
swalrus1
swalrus1 reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@swalrus1 swalrus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Sep 12, 2024
Merged
Merged
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@ivanmorozov333 @zverevgeny
speed up logging exp (ydb-platform#9087)
7f6818a
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
This was referenced Sep 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalrus1 swalrus1 swalrus1 left review comments

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanmorozov333 @swalrus1 @zverevgeny