Skip to content

Fix PARTITION_COUNT option name and add tests #9012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

fexolm
Copy link
Contributor

@fexolm fexolm commented Sep 10, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@fexolm fexolm requested a review from a team as a code owner September 10, 2024 12:45
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 12:47:58 UTC Pre-commit check linux-x86_64-release-asan for e6e9bb2 has started.
2024-09-10 12:48:37 UTC Artifacts will be uploaded here
2024-09-10 12:51:50 UTC ya make is running...
🔴 2024-09-10 14:22:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12824 12745 0 18 33 28

🟢 2024-09-10 14:24:03 UTC Build successful.
🟡 2024-09-10 14:24:30 UTC ydbd size 5.6 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f11c0b2 merge: e6e9bb2 diff diff %
ydbd size 6 037 343 296 Bytes 6 038 706 488 Bytes +1.3 MiB +0.023%
ydbd stripped size 1 511 159 472 Bytes 1 511 287 248 Bytes +124.8 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 12:48:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6e9bb2 has started.
2024-09-10 12:49:18 UTC Artifacts will be uploaded here
2024-09-10 12:52:41 UTC ya make is running...
🟡 2024-09-10 14:05:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75094 61273 0 7 13787 27

2024-09-10 14:13:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 14:24:12 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 29 0 0 1 21

🟢 2024-09-10 14:24:20 UTC Build successful.
🟢 2024-09-10 14:25:01 UTC ydbd size 8.4 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a7d2186 merge: e6e9bb2 diff diff %
ydbd size 9 026 353 128 Bytes 9 026 353 096 Bytes -32 Bytes -0.000%
ydbd stripped size 487 744 168 Bytes 487 744 168 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 12:49:06 UTC Pre-commit check linux-x86_64-release-clang14 for e6e9bb2 has started.
2024-09-10 12:49:16 UTC Artifacts will be uploaded here
2024-09-10 12:52:05 UTC ya make is running...
🟢 2024-09-10 13:02:20 UTC Build successful.

@fexolm fexolm enabled auto-merge (squash) September 10, 2024 13:33
@fexolm fexolm merged commit 26c9911 into ydb-platform:main Sep 10, 2024
11 of 13 checks passed
@fexolm fexolm deleted the fexolm/test-partition-count branch September 10, 2024 17:39
@shnikd shnikd mentioned this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
Conflicts:
	ydb/library/yql/sql/v1/sql_ut.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Conflicts:
	ydb/library/yql/sql/v1/sql_ut.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants