Skip to content

Disallow disabling of topic autopartitioning #8871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@nshestakov nshestakov requested a review from a team as a code owner September 6, 2024 13:28
alexnick88
alexnick88 previously approved these changes Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 13:31:28 UTC Pre-commit check for 6bbb441 has started.
2024-09-06 13:34:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-06 13:55:52 UTC Build successful.
2024-09-06 13:56:09 UTC Tests are running...
🔴 2024-09-06 15:51:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9902 9830 0 10 28 34

🟢 2024-09-06 15:52:27 UTC ydbd size 5.5 GiB changed* by -2.5 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 1bb608a merge: 6bbb441 diff diff %
ydbd size 5 934 627 792 Bytes 5 934 625 184 Bytes -2.5 KiB -0.000%
ydbd stripped size 1 487 865 920 Bytes 1 487 865 280 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 13:33:20 UTC Pre-commit check for 6bbb441 has started.
2024-09-06 13:35:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-06 13:59:40 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 13:46:31 UTC Pre-commit check for 6bbb441 has started.
2024-09-06 13:49:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-06 14:27:45 UTC Build successful.
2024-09-06 14:28:02 UTC Tests are running...
🔴 2024-09-06 16:00:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14203 12865 0 7 1300 31

🟢 2024-09-06 16:01:14 UTC ydbd size 8.2 GiB changed* by -2.7 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 1bb608a merge: 6bbb441 diff diff %
ydbd size 8 760 905 424 Bytes 8 760 902 688 Bytes -2.7 KiB -0.000%
ydbd stripped size 478 998 152 Bytes 478 998 024 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:21:53 UTC Pre-commit check for 115e9f8 has started.
2024-09-06 17:24:19 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-09-06 17:26:59 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:21:53 UTC Pre-commit check for 115e9f8 has started.
2024-09-06 17:24:23 UTC Build linux-x86_64-release-asan is running...
🔴 2024-09-06 17:26:49 UTC Build failed. see the build logs.
🔴 2024-09-06 17:26:51 UTC Tests run skipped.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:24:16 UTC Pre-commit check for 115e9f8 has started.
2024-09-06 17:26:50 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-09-06 17:29:26 UTC Build failed. see the build logs.
🔴 2024-09-06 17:29:28 UTC Tests run skipped.

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Sep 7, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 14:51:17 UTC Pre-commit check for 115e9f8 has started.
2024-09-07 14:53:45 UTC Build linux-x86_64-release-asan is running...
🔴 2024-09-07 14:56:17 UTC Build failed. see the build logs.
🔴 2024-09-07 14:56:18 UTC Tests run skipped.

Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 14:52:11 UTC Pre-commit check for 115e9f8 has started.
2024-09-07 14:54:43 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-09-07 14:57:31 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 14:53:33 UTC Pre-commit check for 115e9f8 has started.
2024-09-07 14:56:17 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-09-07 14:59:12 UTC Build failed. see the build logs.
🔴 2024-09-07 14:59:14 UTC Tests run skipped.

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Sep 9, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:22:12 UTC Pre-commit check for 36fbd0c has started.
2024-09-09 07:24:41 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-09 07:42:40 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:22:40 UTC Pre-commit check for 36fbd0c has started.
2024-09-09 07:25:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-09 08:08:01 UTC Build successful.
2024-09-09 08:08:18 UTC Tests are running...
🔴 2024-09-09 09:31:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14203 12868 0 5 1299 31

🟡 2024-09-09 09:32:02 UTC ydbd size 8.2 GiB changed* by +116.2 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 871adef merge: 36fbd0c diff diff %
ydbd size 8 760 911 888 Bytes 8 761 030 896 Bytes +116.2 KiB +0.001%
ydbd stripped size 478 998 600 Bytes 478 998 472 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:22:44 UTC Pre-commit check for 36fbd0c has started.
2024-09-09 07:25:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-09 07:51:34 UTC Build successful.
2024-09-09 07:51:50 UTC Tests are running...
🔴 2024-09-09 09:36:40 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9900 9840 0 5 24 31

🟢 2024-09-09 09:37:16 UTC ydbd size 5.5 GiB changed* by -312 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 871adef merge: 36fbd0c diff diff %
ydbd size 5 934 636 968 Bytes 5 934 636 656 Bytes -312 Bytes -0.000%
ydbd stripped size 1 487 867 776 Bytes 1 487 867 200 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit 178f147 into ydb-platform:stable-24-3 Sep 9, 2024
14 of 22 checks passed
@nshestakov nshestakov deleted the fixAutopartitionDisable branch September 9, 2024 10:33
nshestakov added a commit to nshestakov/ydb that referenced this pull request Sep 9, 2024
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants