24-3: Fix resolved timestamp emitted too early for some displaced upserts

[snaury]

Changelog entry

Fix resolved timestamp emitted too early for some displaced upserts

Changelog category

• Bugfix

Additional information

When an upsert is displaced (when current timestamp is blocked by a repeatable read) and shares timestamp with the next scheduled heartbeat, it was possible for that heartbeat to emit while we may still add more writes with that timestamp. The issue is fixed by using the correct comparison.

Found this bug while investigating #6985.

[github-actions]

⚪ 2024-09-06 13:22:42 UTC Pre-commit check for a21e64f has started.
⚪ 2024-09-06 13:25:41 UTC Build linux-x86_64-release-asan is running...
🔴 2024-09-06 13:25:56 UTC Build failed. see the build logs.
🔴 2024-09-06 13:25:57 UTC Tests run skipped.

[github-actions]

⚪ 2024-09-06 13:29:12 UTC Pre-commit check for a21e64f has started.
⚪ 2024-09-06 13:32:08 UTC Build linux-x86_64-relwithdebinfo is running...

[github-actions]

⚪ 2024-09-06 13:29:12 UTC Pre-commit check for a21e64f has started.

[github-actions]

⚪ 2024-09-06 16:26:08 UTC Pre-commit check for 720647d has started.
⚪ 2024-09-06 16:29:37 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-09-06 16:32:41 UTC Build failed. see the build logs.

[github-actions]

⚪ 2024-09-06 16:26:24 UTC Pre-commit check for 720647d has started.
⚪ 2024-09-06 16:30:02 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-09-06 16:33:10 UTC Build failed. see the build logs.
🔴 2024-09-06 16:33:11 UTC Tests run skipped.

[github-actions]

⚪ 2024-09-06 16:27:03 UTC Pre-commit check for 720647d has started.
⚪ 2024-09-06 16:30:48 UTC Build linux-x86_64-release-asan is running...
🔴 2024-09-06 16:33:33 UTC Build failed. see the build logs.
🔴 2024-09-06 16:33:35 UTC Tests run skipped.

[github-actions]

⚪ 2024-09-09 07:31:15 UTC Pre-commit check for 70e7731 has started.
⚪ 2024-09-09 07:33:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-09 07:45:55 UTC Build successful.

[github-actions]

⚪ 2024-09-09 07:33:03 UTC Pre-commit check for 70e7731 has started.
⚪ 2024-09-09 07:35:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-09 07:57:15 UTC Build successful.
⚪ 2024-09-09 07:57:37 UTC Tests are running...
🔴 2024-09-09 09:48:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
9902	9833	0	10	25	34

🟢 2024-09-09 09:48:58 UTC ydbd size 5.5 GiB changed* by -1.2 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash	stable-24-3: 871adef	merge: 70e7731	diff	diff %
ydbd size	5 934 636 968 Bytes	5 934 635 784 Bytes	-1.2 KiB	-0.000%
ydbd stripped size	1 487 867 776 Bytes	1 487 866 880 Bytes	-896 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-09-09 07:33:07 UTC Pre-commit check for 70e7731 has started.
⚪ 2024-09-09 07:35:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-09 08:15:54 UTC Build successful.
⚪ 2024-09-09 08:16:09 UTC Tests are running...
🔴 2024-09-09 09:37:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
14202	12865	0	6	1301	30

🟡 2024-09-09 09:38:25 UTC ydbd size 8.2 GiB changed* by +116.6 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash	stable-24-3: 871adef	merge: 70e7731	diff	diff %
ydbd size	8 760 911 888 Bytes	8 761 031 256 Bytes	+116.6 KiB	+0.001%
ydbd stripped size	478 998 600 Bytes	478 998 408 Bytes	-192 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}