Skip to content

add missing enum value to win-specific code #8854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Sep 6, 2024

fix compilation for windows (untested)

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:53:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 283d6c5 has started.
2024-09-06 10:56:45 UTC ya make is running...
🟡 2024-09-06 12:05:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39502 34042 0 5 5428 27

2024-09-06 12:09:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 12:20:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 26 0 0 1 21

🟢 2024-09-06 12:20:19 UTC Build successful.
🟢 2024-09-06 12:21:02 UTC ydbd size 8.4 GiB changed* by +86.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0b897b9 merge: 283d6c5 diff diff %
ydbd size 9 013 279 192 Bytes 9 013 367 736 Bytes +86.5 KiB +0.001%
ydbd stripped size 487 289 416 Bytes 487 291 368 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:54:52 UTC Pre-commit check linux-x86_64-release-asan for 283d6c5 has started.
2024-09-06 10:57:53 UTC ya make is running...
🔴 2024-09-06 12:48:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10271 10147 0 49 38 37

🟢 2024-09-06 12:49:26 UTC Build successful.
🟢 2024-09-06 12:50:01 UTC ydbd size 5.6 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7770159 merge: 283d6c5 diff diff %
ydbd size 6 028 974 952 Bytes 6 028 974 840 Bytes -112 Bytes -0.000%
ydbd stripped size 1 509 662 256 Bytes 1 509 662 192 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:55:37 UTC Pre-commit check linux-x86_64-release-clang14 for 283d6c5 has started.
2024-09-06 10:58:25 UTC ya make is running...
🟢 2024-09-06 11:03:34 UTC Build successful.

@swalrus1 swalrus1 marked this pull request as ready for review September 6, 2024 10:56
@swalrus1 swalrus1 enabled auto-merge (squash) September 6, 2024 10:58
@swalrus1 swalrus1 merged commit 1257b2f into ydb-platform:main Sep 6, 2024
12 of 14 checks passed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
@shnikd shnikd mentioned this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants