Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Sep 3, 2024

Changelog entry

Changes from PR 8517.

The entry for WriteId was not saved if there was an empty list of partitions in TTxWriteInfo. As a result, after restoring the tablet, Y_VERIFY was triggered.

Now the record of the WriteId is saved until the end of the transaction.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 3, 2024 11:20
@github-actions
Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 11:51:30 UTC Pre-commit check for 6309422 has started.
2024-09-03 11:54:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-03 12:26:40 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 12:05:25 UTC Pre-commit check for 6309422 has started.
2024-09-03 12:08:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-03 12:50:12 UTC Build successful.
2024-09-03 12:50:26 UTC Tests are running...
🔴 2024-09-03 14:42:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38516 33273 0 2 5212 29

🟢 2024-09-03 14:43:01 UTC ydbd size 8.2 GiB changed* by +52.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 250822e merge: 6309422 diff diff %
ydbd size 8 760 189 584 Bytes 8 760 242 920 Bytes +52.1 KiB +0.001%
ydbd stripped size 478 952 712 Bytes 478 956 424 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 12:11:35 UTC Pre-commit check for 6309422 has started.
2024-09-03 12:14:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-03 12:40:33 UTC Build successful.
2024-09-03 12:40:54 UTC Tests are running...
🔴 2024-09-03 14:42:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9989 9913 0 17 27 32

🟢 2024-09-03 14:43:40 UTC ydbd size 5.5 GiB changed* by +41.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 250822e merge: 6309422 diff diff %
ydbd size 5 933 703 968 Bytes 5 933 746 544 Bytes +41.6 KiB +0.001%
ydbd stripped size 1 487 691 616 Bytes 1 487 699 488 Bytes +7.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants