Skip to content

fix(kqp): always take snapshot for queries with stream lookup (#8267) #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ulya-sidorina
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 09:45:29 UTC Pre-commit check for 6d5c07d has started.
2024-08-27 09:48:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-27 10:26:43 UTC Build successful.
2024-08-27 10:26:56 UTC Tests are running...
🔴 2024-08-27 12:07:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38455 33228 0 4 5212 11

🟢 2024-08-27 12:08:03 UTC ydbd size 8.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 57fe08e merge: 6d5c07d diff diff %
ydbd size 8 726 033 600 Bytes 8 726 033 552 Bytes -48 Bytes -0.000%
ydbd stripped size 476 971 592 Bytes 476 971 592 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 09:46:50 UTC Pre-commit check for 6d5c07d has started.
2024-08-27 09:49:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-27 09:54:44 UTC Build successful.

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 09:47:03 UTC Pre-commit check for 6d5c07d has started.
2024-08-27 09:50:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-27 10:12:07 UTC Build successful.
2024-08-27 10:12:22 UTC Tests are running...
🔴 2024-08-27 12:05:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9927 9879 0 9 25 14

🟢 2024-08-27 12:06:16 UTC ydbd size 5.5 GiB changed* by -64 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 57fe08e merge: 6d5c07d diff diff %
ydbd size 5 905 778 960 Bytes 5 905 778 896 Bytes -64 Bytes -0.000%
ydbd stripped size 1 480 457 728 Bytes 1 480 457 664 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ulya-sidorina ulya-sidorina marked this pull request as ready for review August 27, 2024 09:47
@ulya-sidorina ulya-sidorina requested a review from a team as a code owner August 27, 2024 09:47
@ulya-sidorina ulya-sidorina merged commit df7e1b2 into ydb-platform:stable-24-3 Sep 5, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream lookup always needs snapshot (for ISOLATION_LEVEL_SERIALIZABLE)
3 participants