Introduce InitialAllocation option for storage load actor, KIKIMR-20619 #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 817ecac.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 817ecac.
|
va-kuznecov
requested changes
Jan 10, 2024
|
|
||
| std::unique_ptr<TEvBlobStorage::TEvCollectGarbage> ManageKeepFlags(ui64 tabletId, ui32 gen, ui32 step, | ||
| ui32 channel, bool keep) { | ||
| auto blobsWritten = std::make_unique<TVector<TLogoBlobID>>(ConfirmedBlobs); |
There was a problem hiding this comment.
выглядит так, что ты по несколько раз будешь посылать keep флаги на одни и де же блобы?
может и ок, но что если там будут 1к-10к-100к блобов?
There was a problem hiding this comment.
Этот метод вызывается один раз после того, как допишется последний блоб
serbel324
force-pushed
the
bs/load-test/initial-allocation
branch
3 times, most recently
from
37238ba to
1b64f94
Compare
serbel324
force-pushed
the
bs/load-test/initial-allocation
branch
from
1b64f94 to
817ecac
Compare
va-kuznecov
approved these changes
Jan 10, 2024
Merged
This was referenced Jan 15, 2024
Closed
Closed
Merged
Merged
This was referenced Jan 25, 2024
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.