Skip to content

YQ-3410 improve s3 url escape, added '#', '?' symbols #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2024
Merged

YQ-3410 improve s3 url escape, added '#', '?' symbols #7881

merged 3 commits into from
Aug 16, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 16, 2024 •
edited
Loading

Changelog entry

Improve s3 url escape

Changelog category

  • Bugfix

Additional information

Added escape for chars '#', '?'

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 16, 2024 07:13
@GrigoriyPA GrigoriyPA requested a review from uzhastik August 16, 2024 07:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:16:30 UTC Pre-commit check for 0b7b263 has started.
⚫ 2024-08-16 07:20:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:16:36 UTC Pre-commit check for 0b7b263 has started.
⚫ 2024-08-16 07:20:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:16:48 UTC Pre-commit check for 0b7b263 has started.
⚫ 2024-08-16 07:19:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:21:45 UTC Pre-commit check for c4e483c has started.
⚪ 2024-08-16 07:25:28 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 07:30:49 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:21:48 UTC Pre-commit check for c4e483c has started.
⚪ 2024-08-16 07:24:31 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-16 09:05:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 07:24:17 UTC Pre-commit check for c4e483c has started.
⚪ 2024-08-16 07:27:43 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-16 08:51:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38682 33338 0 4 5309 31

⚪ 2024-08-16 08:54:19 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 09:02:44 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 19 0 0 1 28

🟢 2024-08-16 09:02:51 UTC Build successful.
🟢 2024-08-16 09:03:27 UTC ydbd size 8.1 GiB changed* by +35.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 83b9579 merge: c4e483c diff diff %
ydbd size 8 733 045 240 Bytes 8 733 081 656 Bytes +35.6 KiB +0.000%
ydbd stripped size 475 302 728 Bytes 475 303 368 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

uzhastik
uzhastik reviewed Aug 16, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 09:08:50 UTC Pre-commit check for 7e754fd has started.
⚪ 2024-08-16 09:11:41 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 09:17:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 09:08:59 UTC Pre-commit check for 7e754fd has started.
⚪ 2024-08-16 09:12:31 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-16 10:33:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38681 33336 0 3 5309 33

⚪ 2024-08-16 10:36:54 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 10:46:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 21 0 0 1 27

🟢 2024-08-16 10:46:52 UTC Build successful.
🟢 2024-08-16 10:47:25 UTC ydbd size 8.1 GiB changed* by +21.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8796c8a merge: 7e754fd diff diff %
ydbd size 8 733 058 008 Bytes 8 733 080 304 Bytes +21.8 KiB +0.000%
ydbd stripped size 475 302 856 Bytes 475 303 432 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 09:09:03 UTC Pre-commit check for 7e754fd has started.
⚪ 2024-08-16 09:11:51 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-16 12:06:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9850 9779 0 13 24 34

🟢 2024-08-16 12:07:33 UTC Build successful.
🟢 2024-08-16 12:08:03 UTC ydbd size 5.5 GiB changed* by +15.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8796c8a merge: 7e754fd diff diff %
ydbd size 5 878 663 528 Bytes 5 878 679 472 Bytes +15.6 KiB +0.000%
ydbd stripped size 1 476 901 456 Bytes 1 476 902 736 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from uzhastik August 16, 2024 09:11
@GrigoriyPA GrigoriyPA merged commit 870de13 into ydb-platform:main Aug 16, 2024
10 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3410-improve-s3-url-escape branch August 16, 2024 13:30
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
@GrigoriyPA
YQ-3410 improve s3 url escape, added '#', '?' symbols (ydb-platform#7881
df465f3 
)
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
@GrigoriyPA
YQ-3410 improve s3 url escape, added '#', '?' symbols (ydb-platform#7881
22c0218 
)
This was referenced Aug 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@GrigoriyPA @stanislav-shchetinin
YQ-3410 improve s3 url escape, added '#', '?' symbols (ydb-platform#7881
22f5858 
)
This was referenced Sep 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @uzhastik