Optional columns feature flags #7814

ivanmorozov333 · 2024-08-15T05:07:43Z

Improvement

github-actions · 2024-08-15T05:10:41Z

⚪ 2024-08-15 05:10:41 UTC Pre-commit check for 21aab4e has started.
⚫ 2024-08-15 05:12:06 UTC Check cancelled

github-actions · 2024-08-15T05:11:10Z

⚪ 2024-08-15 05:11:09 UTC Pre-commit check for 21aab4e has started.
⚫ 2024-08-15 05:12:06 UTC Check cancelled

github-actions · 2024-08-15T05:11:10Z

⚪ 2024-08-15 05:11:10 UTC Pre-commit check for 21aab4e has started.
⚫ 2024-08-15 05:12:06 UTC Check cancelled

github-actions · 2024-08-15T05:13:27Z

⚪ 2024-08-15 05:13:27 UTC Pre-commit check for dfd15b6 has started.
⚪ 2024-08-15 05:16:29 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-15 05:32:24 UTC Check cancelled

github-actions · 2024-08-15T05:13:28Z

⚪ 2024-08-15 05:13:27 UTC Pre-commit check for dfd15b6 has started.
⚪ 2024-08-15 05:16:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 05:21:01 UTC Build failed. see the logs.

github-actions · 2024-08-15T05:15:20Z

⚪ 2024-08-15 05:15:20 UTC Pre-commit check for dfd15b6 has started.
⚪ 2024-08-15 05:18:25 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-15 05:32:24 UTC Check cancelled

github-actions · 2024-08-15T05:33:48Z

⚪ 2024-08-15 05:33:47 UTC Pre-commit check for 68f68af has started.

github-actions · 2024-08-15T05:35:45Z

⚪ 2024-08-15 05:35:45 UTC Pre-commit check for 68f68af has started.

github-actions · 2024-08-15T05:35:50Z

⚪ 2024-08-15 05:35:49 UTC Pre-commit check for 68f68af has started.

github-actions · 2024-08-15T06:25:46Z

⚪ 2024-08-15 06:25:45 UTC Pre-commit check for a168511 has started.
⚪ 2024-08-15 06:28:52 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 06:58:16 UTC Build successful.

github-actions · 2024-08-15T06:25:57Z

⚪ 2024-08-15 06:25:57 UTC Pre-commit check for a168511 has started.
⚪ 2024-08-15 06:28:59 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-15 07:02:56 UTC Check cancelled

github-actions · 2024-08-15T06:25:58Z

⚪ 2024-08-15 06:25:58 UTC Pre-commit check for a168511 has started.
⚪ 2024-08-15 06:28:57 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-15 07:02:46 UTC Check cancelled

github-actions · 2024-08-15T07:05:32Z

⚪ 2024-08-15 07:05:32 UTC Pre-commit check for dd68706 has started.
⚪ 2024-08-15 07:08:49 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-15 09:13:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40005	34646	0	8	5317	34

⚪ 2024-08-15 09:17:25 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 09:26:05 UTC ydbd size 8.1 GiB changed* by +83.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `dc00a4b`	merge: `dd68706`	diff	diff %
ydbd size	8 731 740 560 Bytes	8 731 825 944 Bytes	+83.4 KiB	+0.001%
ydbd stripped size	475 247 112 Bytes	475 249 992 Bytes	+2.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-08-15 09:26:07 UTC Check cancelled

github-actions · 2024-08-15T07:06:18Z

⚪ 2024-08-15 07:06:17 UTC Pre-commit check for dd68706 has started.
⚪ 2024-08-15 07:09:16 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 07:14:22 UTC Build successful.

github-actions · 2024-08-15T07:06:34Z

⚪ 2024-08-15 07:06:34 UTC Pre-commit check for dd68706 has started.
⚪ 2024-08-15 07:09:47 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 09:18:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11143	11074	0	15	22	32

🟢 2024-08-15 09:19:48 UTC Build successful.
🟢 2024-08-15 09:20:17 UTC ydbd size 5.5 GiB changed* by +59.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `dc00a4b`	merge: `dd68706`	diff	diff %
ydbd size	5 877 778 440 Bytes	5 877 839 216 Bytes	+59.4 KiB	+0.001%
ydbd stripped size	1 476 699 120 Bytes	1 476 710 288 Bytes	+10.9 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-15T09:35:08Z

⚪ 2024-08-15 09:35:07 UTC Pre-commit check for 1ed9256 has started.
⚪ 2024-08-15 09:38:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 10:15:30 UTC Build successful.

github-actions · 2024-08-15T09:35:40Z

⚪ 2024-08-15 09:35:40 UTC Pre-commit check for 1ed9256 has started.
⚪ 2024-08-15 09:39:27 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-15 11:18:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40008	34656	0	4	5309	39

⚪ 2024-08-15 11:22:23 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 11:33:16 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
54 (only retried tests)	24	0	0	0	30

🟢 2024-08-15 11:33:22 UTC Build successful.
🟢 2024-08-15 11:33:59 UTC ydbd size 8.1 GiB changed* by +63.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `009d3c9`	merge: `1ed9256`	diff	diff %
ydbd size	8 731 657 848 Bytes	8 731 722 456 Bytes	+63.1 KiB	+0.001%
ydbd stripped size	475 248 520 Bytes	475 250 376 Bytes	+1.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-15T09:39:52Z

⚪ 2024-08-15 09:39:52 UTC Pre-commit check for 1ed9256 has started.
⚪ 2024-08-15 09:42:51 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 12:15:21 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11154	11078	0	13	29	34

🟢 2024-08-15 12:16:19 UTC Build successful.
🟢 2024-08-15 12:16:47 UTC ydbd size 5.5 GiB changed* by +45.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `009d3c9`	merge: `1ed9256`	diff	diff %
ydbd size	5 877 743 064 Bytes	5 877 789 264 Bytes	+45.1 KiB	+0.001%
ydbd stripped size	1 476 698 160 Bytes	1 476 709 584 Bytes	+11.2 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

zverevgeny · 2024-08-15T15:04:59Z

ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp

        case NEvWrite::EModificationType::Upsert: {
-            AFL_VERIFY(batch->num_columns() <= dstSchema->num_fields());
+                AFL_VERIFY(batch->num_columns() <= dstSchema->num_fields());


extra indent

Conflicts: ydb/core/protos/feature_flags.proto ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp

github-actions bot added the improvement label Aug 15, 2024

ivanmorozov333 force-pushed the optional_columns_feature_flags branch from 162e58d to 2f6de40 Compare August 15, 2024 09:25

ivanmorozov333 added 7 commits August 15, 2024 12:33

features flag for optional columns

5ec5121

fix

722a075

fix

82eb445

fix build

225b88a

fix

ee4b91f

additional logging

6bfa305

fix

83c8550

ivanmorozov333 force-pushed the optional_columns_feature_flags branch from c1c5e9f to 83c8550 Compare August 15, 2024 09:33

ivanmorozov333 marked this pull request as ready for review August 15, 2024 13:11

zverevgeny approved these changes Aug 15, 2024

View reviewed changes

ivanmorozov333 merged commit 1159d25 into ydb-platform:main Aug 15, 2024
10 of 12 checks passed

ivanmorozov333 deleted the optional_columns_feature_flags branch August 15, 2024 15:06

GrigoriyPA mentioned this pull request Aug 15, 2024

YQ-3557 fixed unit test KqpLimits::ComputeActorMemoryAllocationFailureQueryService with resource pools #7873

Merged

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 15, 2024

Optional columns feature flags (ydb-platform#7814)

3557ee2

Conflicts: ydb/core/protos/feature_flags.proto ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp

niksaveliev mentioned this pull request Aug 21, 2024

Fix describe consumer #8095

Merged

GrigoriyPA mentioned this pull request Aug 21, 2024

YQ kqprun enable runtime listing by default #8096

Merged

niksaveliev mentioned this pull request Aug 29, 2024

Fix pqv1 max partitions #8485

Merged

stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024

Optional columns feature flags (ydb-platform#7814)

da58b50

This was referenced Sep 9, 2024

Fix CLI max partitions default #8944

Merged

Fix reading without consumer from federation #9136

Merged

zverevgeny mentioned this pull request Sep 16, 2024

Integrate latest changes in CS into stable branch #9271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optional columns feature flags #7814

Optional columns feature flags #7814

ivanmorozov333 commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

zverevgeny Aug 15, 2024

Optional columns feature flags #7814

Optional columns feature flags #7814

Conversation

ivanmorozov333 commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

zverevgeny Aug 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading