Skip to content

Add PARTITIONS_COUNT setting to yql #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add PARTITIONS_COUNT setting to yql #7602

merged 1 commit into from
Sep 9, 2024

Conversation

fexolm
Copy link
Contributor

@fexolm fexolm commented Aug 9, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 09:03:45 UTC Pre-commit check for 6642130 has started.
⚪ 2024-08-09 09:06:36 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 09:42:28 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 09:03:54 UTC Pre-commit check for 6642130 has started.
⚪ 2024-08-09 09:06:41 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 11:14:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73243 59629 0 3 13598 13

⚪ 2024-08-09 11:22:10 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 11:29:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 9 0 0 1 8

🟢 2024-08-09 11:29:54 UTC Build successful.
🟢 2024-08-09 11:30:28 UTC ydbd size 8.1 GiB changed* by +14.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 403d37f merge: 6642130 diff diff %
ydbd size 8 688 414 328 Bytes 8 688 429 528 Bytes +14.8 KiB +0.000%
ydbd stripped size 472 744 808 Bytes 472 745 768 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 09:04:06 UTC Pre-commit check for 6642130 has started.
⚪ 2024-08-09 09:06:52 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 11:16:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11683 11626 0 11 33 13

🟢 2024-08-09 11:18:06 UTC Build successful.
🟢 2024-08-09 11:18:36 UTC ydbd size 5.4 GiB changed* by +39.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 403d37f merge: 6642130 diff diff %
ydbd size 5 843 569 184 Bytes 5 843 609 200 Bytes +39.1 KiB +0.001%
ydbd stripped size 1 468 062 000 Bytes 1 468 070 064 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm force-pushed the fexolm/partitions_count_setting branch from 3a09324 to a2cc61d Compare August 29, 2024 09:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:24:38 UTC Pre-commit check linux-x86_64-release-asan for 812be82 has started.
⚪ 2024-08-29 09:27:26 UTC ya make is running...
🔴 2024-08-29 10:54:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12013 11947 0 15 32 19

🟢 2024-08-29 10:55:27 UTC Build successful.
🟢 2024-08-29 10:55:58 UTC ydbd size 5.5 GiB changed* by +43.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 37b4d6c merge: 812be82 diff diff %
ydbd size 5 936 630 776 Bytes 5 936 675 536 Bytes +43.7 KiB +0.001%
ydbd stripped size 1 491 036 880 Bytes 1 491 045 968 Bytes +8.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:25:43 UTC Pre-commit check linux-x86_64-release-clang14 for 812be82 has started.
⚪ 2024-08-29 09:28:30 UTC ya make is running...
🟢 2024-08-29 09:35:03 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:28:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 812be82 has started.
⚪ 2024-08-29 09:31:54 UTC ya make is running...
🟡 2024-08-29 10:45:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74123 60330 0 86 13687 20

⚪ 2024-08-29 10:52:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-08-29 11:00:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 57 0 42 0 14

⚪ 2024-08-29 11:00:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-08-29 11:07:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 24 0 25 0 12

🟢 2024-08-29 11:07:34 UTC Build successful.
🟢 2024-08-29 11:08:20 UTC ydbd size 8.2 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45efac0 merge: 812be82 diff diff %
ydbd size 8 810 199 896 Bytes 8 810 219 312 Bytes +19.0 KiB +0.000%
ydbd stripped size 480 427 016 Bytes 480 428 232 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny reviewed Sep 6, 2024
View reviewed changes
ydb/library/yql/sql/v1/sql_translation.cpp
bool TSqlTranslation::ValidateTableSettings(const TTableSettings& settings) {
if (settings.PartitionsCount) {
if (!settings.StoreType || to_lower(settings.StoreType->Name) != "column") {
Ctx.Error() << " PARTITION_COUNT can be used only with STORE=COLUMN";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь, пожалуйста, тестов, проверяющий что запросы с неправильной комбинацией параметров не будут проходить

@fexolm fexolm marked this pull request as ready for review September 6, 2024 13:20
@fexolm fexolm requested a review from a team as a code owner September 6, 2024 13:20
@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Sep 6, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

⚪ 2024-09-06 13:27:04 UTC Pre-commit check linux-x86_64-release-asan for e2bda74 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

⚪ 2024-09-06 13:30:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for e2bda74 has started.
⚪ 2024-09-06 13:34:19 UTC ya make is running...
🟡 2024-09-06 14:46:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75047 61252 0 5 13767 23

⚪ 2024-09-06 14:53:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 15:00:43 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39 (only retried tests) 22 0 0 0 17

🟢 2024-09-06 15:00:50 UTC Build successful.
🟢 2024-09-06 15:01:33 UTC ydbd size 8.4 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 11a2cb4 merge: e2bda74 diff diff %
ydbd size 9 013 804 336 Bytes 9 013 823 808 Bytes +19.0 KiB +0.000%
ydbd stripped size 487 307 112 Bytes 487 308 392 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

⚪ 2024-09-06 13:30:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for e2bda74 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

⚪ 2024-09-06 13:32:02 UTC Pre-commit check linux-x86_64-release-clang14 for e2bda74 has started.
⚪ 2024-09-06 13:35:45 UTC ya make is running...
🟢 2024-09-06 13:44:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

⚪ 2024-09-06 13:32:02 UTC Pre-commit check linux-x86_64-release-clang14 for e2bda74 has started.

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

⚪ 2024-09-06 13:32:02 UTC Pre-commit check linux-x86_64-release-clang14 for e2bda74 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

⚪ 2024-09-06 13:32:02 UTC Pre-commit check linux-x86_64-release-clang14 for e2bda74 has started.

@fexolm fexolm added the rebase-and-check Rebase PR with the current base branch and check label Sep 9, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 08:50:30 UTC Pre-commit check linux-x86_64-release-clang14 for 86dd5ba has started.
⚪ 2024-09-09 08:53:32 UTC ya make is running...
🟢 2024-09-09 09:05:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 08:51:01 UTC Pre-commit check linux-x86_64-release-asan for 86dd5ba has started.
⚪ 2024-09-09 08:54:03 UTC ya make is running...
🔴 2024-09-09 10:37:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12814 12708 0 31 46 29

🟢 2024-09-09 10:38:21 UTC Build successful.
🟢 2024-09-09 10:38:54 UTC ydbd size 5.6 GiB changed* by +43.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e546733 merge: 86dd5ba diff diff %
ydbd size 6 032 001 928 Bytes 6 032 046 160 Bytes +43.2 KiB +0.001%
ydbd stripped size 1 510 131 824 Bytes 1 510 140 656 Bytes +8.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 08:51:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 86dd5ba has started.
⚪ 2024-09-09 08:54:44 UTC ya make is running...
🟡 2024-09-09 10:14:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75060 61236 0 9 13778 37

⚪ 2024-09-09 10:22:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-09 10:32:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 40 0 0 1 18

🟢 2024-09-09 10:32:30 UTC Build successful.
🟢 2024-09-09 10:33:11 UTC ydbd size 8.4 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e546733 merge: 86dd5ba diff diff %
ydbd size 9 017 220 344 Bytes 9 017 239 752 Bytes +19.0 KiB +0.000%
ydbd stripped size 487 420 872 Bytes 487 422 088 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm merged commit 2ab0fd8 into ydb-platform:main Sep 9, 2024
17 of 22 checks passed
@fexolm fexolm deleted the fexolm/partitions_count_setting branch September 9, 2024 13:03
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
@fexolm @zverevgeny
Add PARTITIONS_COUNT setting to yql (ydb-platform#7602)
d1f0ead
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 10, 2024
Merged
@shnikd shnikd mentioned this pull request Sep 11, 2024
Closed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
@fexolm @zverevgeny
Add PARTITIONS_COUNT setting to yql (ydb-platform#7602)
1c38f6c
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
@fexolm @zverevgeny
Add PARTITIONS_COUNT setting to yql (ydb-platform#7602)
050fef5
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@fexolm @zverevgeny
Add PARTITIONS_COUNT setting to yql (ydb-platform#7602)
829626e
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fexolm @vitstn @zverevgeny