Skip to content

Allow multiple join-broadcasts in single stage #7556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Aug 8, 2024

Changelog category

  • Bugfix

@github-actions github-actions bot added the bugfix label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:32:55 UTC Pre-commit check for b8071ee has started.
2024-08-08 09:36:06 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 09:39:02 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:33:06 UTC Pre-commit check for b8071ee has started.
2024-08-08 09:36:05 UTC Check linux-x86_64-release-asan is running...
🟢 2024-08-08 09:40:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 281 0 0 0 0

🟢 2024-08-08 09:40:25 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:40:05 UTC Pre-commit check for b8071ee has started.
2024-08-08 09:42:20 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 09:45:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 281 0 0 0 0

🟢 2024-08-08 09:45:53 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:54:54 UTC Pre-commit check for 103b2df has started.
2024-08-08 09:58:03 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 10:02:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 280 0 1 0 0

🟢 2024-08-08 10:02:45 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:54:59 UTC Pre-commit check for 103b2df has started.
2024-08-08 09:57:14 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 10:00:14 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 09:55:07 UTC Pre-commit check for 103b2df has started.
2024-08-08 09:57:28 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 10:01:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 280 0 1 0 0

2024-08-08 10:01:27 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 10:02:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1 (only retried tests) 0 0 1 0 0

2024-08-08 10:02:21 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-08 10:03:01 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1 (only retried tests) 0 0 1 0 0

🟢 2024-08-08 10:03:08 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 06:53:39 UTC Pre-commit check for ae565c3 has started.
2024-08-12 06:54:34 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 06:56:01 UTC Pre-commit check for ab1292f has started.
2024-08-12 06:58:41 UTC Check linux-x86_64-release-asan is running...
2024-08-12 08:20:16 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 06:56:58 UTC Pre-commit check for ab1292f has started.
2024-08-12 06:59:39 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 07:05:24 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 06:59:16 UTC Pre-commit check for ab1292f has started.
2024-08-12 07:01:55 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-12 08:20:17 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:22:26 UTC Pre-commit check for 5e8c938 has started.
2024-08-12 08:25:27 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 08:30:29 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:22:51 UTC Pre-commit check for 5e8c938 has started.
2024-08-12 08:25:37 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 10:40:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9690 9640 0 10 23 17

🟢 2024-08-12 10:42:03 UTC Build successful.
🟢 2024-08-12 10:42:30 UTC ydbd size 5.4 GiB changed* by -8.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a2e8760 merge: 5e8c938 diff diff %
ydbd size 5 846 754 776 Bytes 5 846 746 488 Bytes -8.1 KiB -0.000%
ydbd stripped size 1 468 579 088 Bytes 1 468 577 168 Bytes -1.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 08:24:06 UTC Pre-commit check for 5e8c938 has started.
2024-08-12 08:26:57 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-12 10:05:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13856 12502 0 2 1339 13

2024-08-12 10:07:13 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-12 10:14:38 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 10 0 0 0 8

🟢 2024-08-12 10:14:45 UTC Build successful.
🟢 2024-08-12 10:15:18 UTC ydbd size 8.1 GiB changed* by -3.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a2e8760 merge: 5e8c938 diff diff %
ydbd size 8 694 050 184 Bytes 8 694 046 632 Bytes -3.5 KiB -0.000%
ydbd stripped size 472 889 384 Bytes 472 888 936 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ssmike ssmike changed the title add qs autochoose test Allow multiple join-broadcasts in single stage Aug 12, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 12, 2024
}
} else {
// 1. All stage's inputs, except 1st one, must be a `Broadcast` or `UnionAll`
// 2. 1st `Broadcast` is handled as `UnionAll`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По формулировке:
1st Broadcastнеоднозначно: первый из бродкастов или первый конекшн, который является бродкастом?

По сути:
Что это по сути значит? Любой бродкаст в стадию с одним таском кажется эквивалентен UnionAll, в чем тут специфика первого?

Copy link
Collaborator Author

@ssmike ssmike Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Гм, я имел ввиду что получится ровно один таск, как в случае "партиционирования" по UnionAll. Вероятно и правда лучше так и написать

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:20:35 UTC Pre-commit check for dc0c2e8 has started.
2024-08-12 11:23:23 UTC Check linux-x86_64-release-asan is running...
2024-08-12 12:11:45 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:20:39 UTC Pre-commit check for dc0c2e8 has started.
2024-08-12 11:23:33 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-12 12:12:08 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 11:21:13 UTC Pre-commit check for dc0c2e8 has started.
2024-08-12 11:24:30 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 11:30:41 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:15:33 UTC Pre-commit check for 6b59f9e has started.
2024-08-12 12:18:22 UTC Check linux-x86_64-release-asan is running...
2024-08-12 12:26:54 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:15:40 UTC Pre-commit check for 6b59f9e has started.
2024-08-12 12:18:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 12:25:06 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:15:52 UTC Pre-commit check for 6b59f9e has started.
2024-08-12 12:18:41 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-12 12:26:57 UTC Check cancelled

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:30:23 UTC Pre-commit check for 2f99237 has started.
2024-08-12 12:33:01 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 12:38:48 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:30:41 UTC Pre-commit check for 2f99237 has started.
2024-08-12 12:33:21 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 15:06:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9686 9642 0 6 24 14

🟢 2024-08-12 15:07:36 UTC Build successful.
🟢 2024-08-12 15:08:05 UTC ydbd size 5.4 GiB changed* by -8.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5a68445 merge: 2f99237 diff diff %
ydbd size 5 846 943 400 Bytes 5 846 935 176 Bytes -8.0 KiB -0.000%
ydbd stripped size 1 468 616 752 Bytes 1 468 614 896 Bytes -1.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 12:31:04 UTC Pre-commit check for 2f99237 has started.
2024-08-12 12:34:55 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-12 13:44:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13868 12510 0 3 1339 16

2024-08-12 13:46:35 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-12 13:56:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 18 0 0 0 8

🟢 2024-08-12 13:56:52 UTC Build successful.
🟢 2024-08-12 13:57:27 UTC ydbd size 8.1 GiB changed* by -3.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5a68445 merge: 2f99237 diff diff %
ydbd size 8 694 239 664 Bytes 8 694 236 176 Bytes -3.4 KiB -0.000%
ydbd stripped size 472 901 320 Bytes 472 900 936 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 17:55:32 UTC Pre-commit check for 676103a has started.
2024-08-12 17:59:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 18:12:25 UTC Build successful.

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 17:55:35 UTC Pre-commit check for 676103a has started.
2024-08-12 17:58:17 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 19:54:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9697 9658 0 2 22 15

🟢 2024-08-12 19:55:28 UTC Build successful.
🟢 2024-08-12 19:55:54 UTC ydbd size 5.4 GiB changed* by -8.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a536da4 merge: 676103a diff diff %
ydbd size 5 851 258 696 Bytes 5 851 250 488 Bytes -8.0 KiB -0.000%
ydbd stripped size 1 469 332 048 Bytes 1 469 330 192 Bytes -1.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 12, 2024

2024-08-12 17:56:05 UTC Pre-commit check for 676103a has started.
2024-08-12 17:58:51 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-12 19:16:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13879 12526 0 3 1336 14

2024-08-12 19:17:56 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-12 19:25:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 12 0 0 1 8

🟢 2024-08-12 19:25:18 UTC Build successful.
🟢 2024-08-12 19:25:52 UTC ydbd size 8.1 GiB changed* by -3.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a536da4 merge: 676103a diff diff %
ydbd size 8 700 331 760 Bytes 8 700 328 208 Bytes -3.5 KiB -0.000%
ydbd stripped size 473 078 792 Bytes 473 078 344 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants