-
Notifications
You must be signed in to change notification settings - Fork 638
Allow multiple join-broadcasts in single stage #7556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚪
🟢 |
⚪ ⚪
⚪
🟢 |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
} | ||
} else { | ||
// 1. All stage's inputs, except 1st one, must be a `Broadcast` or `UnionAll` | ||
// 2. 1st `Broadcast` is handled as `UnionAll` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
По формулировке:
1st Broadcast
неоднозначно: первый из бродкастов или первый конекшн, который является бродкастом?
По сути:
Что это по сути значит? Любой бродкаст в стадию с одним таском кажется эквивалентен UnionAll, в чем тут специфика первого?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Гм, я имел ввиду что получится ровно один таск, как в случае "партиционирования" по UnionAll. Вероятно и правда лучше так и написать
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category