Skip to content

stable-24-3: Enable COUNT in view queries (#6820) #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Aug 7, 2024

Enables aggregate functions inside views by:

  • providing ModuleResolver from KQP host to CompileExpr function
  • repeating ExpandApplyForLambdas transformation step when rewriting a read from a view

Same as #6820.

See also similar PR to stable-24-2.

Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 06:33:08 UTC Pre-commit check for b123a65 has started.
2024-08-07 06:35:36 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-07 06:42:00 UTC Build successful.

Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 06:33:12 UTC Pre-commit check for b123a65 has started.
2024-08-07 06:35:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-07 06:59:39 UTC Build successful.
2024-08-07 06:59:54 UTC Tests are running...
🔴 2024-08-07 08:44:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9903 9855 0 8 26 14

🟢 2024-08-07 08:44:50 UTC ydbd size 5.5 GiB changed* by -200.8 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 4e8a96c merge: b123a65 diff diff %
ydbd size 5 903 518 456 Bytes 5 903 312 888 Bytes -200.8 KiB -0.003%
ydbd stripped size 1 480 189 152 Bytes 1 480 106 656 Bytes -80.6 KiB -0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 7, 2024

2024-08-07 06:35:21 UTC Pre-commit check for b123a65 has started.
2024-08-07 06:37:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-07 07:14:47 UTC Build successful.
2024-08-07 07:15:03 UTC Tests are running...
🔴 2024-08-07 08:55:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38427 33190 0 1 5221 15

🟢 2024-08-07 08:56:55 UTC ydbd size 8.1 GiB changed* by -259.5 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 4e8a96c merge: b123a65 diff diff %
ydbd size 8 721 971 512 Bytes 8 721 705 800 Bytes -259.5 KiB -0.003%
ydbd stripped size 476 893 032 Bytes 476 877 544 Bytes -15.1 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 changed the title Enable COUNT in view queries (#6820) stable-24-3: Enable COUNT in view queries (#6820) Aug 7, 2024
@jepett0 jepett0 marked this pull request as ready for review August 7, 2024 08:33
@jepett0 jepett0 requested a review from a team as a code owner August 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants