Skip to content

YQ-3491 support sql for resource pool classifiers #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 2, 2024

Changelog entry

Support sql for resource pool classifiers

Changelog category

  • New feature

Additional information

Добавляется в рамках тикета:
https://st.yandex-team.ru/YQ-3491

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 2, 2024 06:12
@GrigoriyPA GrigoriyPA requested a review from dorooleg August 2, 2024 06:12
@GrigoriyPA GrigoriyPA requested a review from nepal August 2, 2024 06:12
Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 06:13:16 UTC Pre-commit check for 4f4076c has started.
2024-08-02 06:16:18 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 08:30:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73109 59493 0 4 13589 23

2024-08-02 08:39:40 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 08:47:25 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 14 0 0 2 12

🟢 2024-08-02 08:54:06 UTC Build successful.
🟡 2024-08-02 08:54:39 UTC ydbd size 8.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4a90cf0 merge: 4f4076c diff diff %
ydbd size 8 674 777 432 Bytes 8 676 202 960 Bytes +1.4 MiB +0.016%
ydbd stripped size 472 125 032 Bytes 472 312 104 Bytes +182.7 KiB +0.040%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 06:13:17 UTC Pre-commit check for 4f4076c has started.
2024-08-02 06:16:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 08:33:38 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11624 11555 0 14 40 15

🟢 2024-08-02 08:34:59 UTC Build successful.
🟡 2024-08-02 08:35:31 UTC ydbd size 5.4 GiB changed* by +1.5 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4a90cf0 merge: 4f4076c diff diff %
ydbd size 5 842 864 776 Bytes 5 844 391 944 Bytes +1.5 MiB +0.026%
ydbd stripped size 1 464 165 712 Bytes 1 464 660 528 Bytes +483.2 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 06:14:57 UTC Pre-commit check for 4f4076c has started.
2024-08-02 06:17:51 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-02 06:24:40 UTC Build successful.

Copy link
Collaborator

@nepal nepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем вы добавляете alter_table_set_table_setting_uncompat в новый код?
Это ведь Legacy из какого-то старого statement

@GrigoriyPA
Copy link
Collaborator Author

Зачем вы добавляете alter_table_set_table_setting_uncompat в новый код? Это ведь Legacy из какого-то старого statement

Делаем по аналогии с table, external table и resource pool:

Наверное будет странно, если для одних (resource pool) будет такой синтаксис, а для resource pool classifier его не будет

@GrigoriyPA GrigoriyPA requested a review from nepal August 4, 2024 15:31
Copy link

github-actions bot commented Aug 5, 2024

2024-08-05 07:32:06 UTC Pre-commit check for 6b4a14b has started.
2024-08-05 07:35:27 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 07:42:56 UTC Build successful.

Copy link

github-actions bot commented Aug 5, 2024

2024-08-05 07:33:37 UTC Pre-commit check for 6b4a14b has started.
2024-08-05 07:36:32 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-05 09:33:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11643 11592 0 3 33 15

🟢 2024-08-05 09:34:43 UTC Build successful.
🟡 2024-08-05 09:35:13 UTC ydbd size 5.4 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d670 merge: 6b4a14b diff diff %
ydbd size 5 825 703 504 Bytes 5 826 977 576 Bytes +1.2 MiB +0.022%
ydbd stripped size 1 463 157 232 Bytes 1 463 509 584 Bytes +344.1 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 5, 2024

2024-08-05 07:34:15 UTC Pre-commit check for 6b4a14b has started.
2024-08-05 07:37:13 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-05 09:50:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73133 59526 0 5 13589 13

2024-08-05 09:59:29 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-05 10:08:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 11 0 0 0 9

🟢 2024-08-05 10:15:07 UTC Build successful.
🟡 2024-08-05 10:16:08 UTC ydbd size 8.1 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d670 merge: 6b4a14b diff diff %
ydbd size 8 665 991 720 Bytes 8 667 198 744 Bytes +1.2 MiB +0.014%
ydbd stripped size 471 452 840 Bytes 471 562 376 Bytes +107.0 KiB +0.023%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA force-pushed the YQ-3491-support-sql-for-resource-pool-classifiers branch from 26a9637 to d79f0ce Compare August 6, 2024 04:00
@GrigoriyPA GrigoriyPA force-pushed the YQ-3491-support-sql-for-resource-pool-classifiers branch from d79f0ce to 412da6e Compare August 6, 2024 04:25
Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 04:28:58 UTC Pre-commit check for a2275dd has started.
2024-08-06 04:32:19 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-06 04:41:38 UTC Build successful.

Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 04:29:04 UTC Pre-commit check for a2275dd has started.
2024-08-06 04:33:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-06 06:31:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11650 11601 0 4 31 14

🟢 2024-08-06 06:33:02 UTC Build successful.
🟡 2024-08-06 06:33:28 UTC ydbd size 5.4 GiB changed* by +963.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 41cd042 merge: a2275dd diff diff %
ydbd size 5 830 490 304 Bytes 5 831 476 408 Bytes +963.0 KiB +0.017%
ydbd stripped size 1 464 451 760 Bytes 1 464 754 384 Bytes +295.5 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 04:29:05 UTC Pre-commit check for a2275dd has started.
2024-08-06 04:32:21 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-06 06:42:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73141 59532 0 4 13591 14

2024-08-06 06:52:10 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-06 07:03:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 8 0 2 5 9

2024-08-06 07:10:37 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-06 07:19:20 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 7 0 0 0 9

🟢 2024-08-06 07:25:53 UTC Build successful.
🟡 2024-08-06 07:26:37 UTC ydbd size 8.1 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 41cd042 merge: a2275dd diff diff %
ydbd size 8 671 674 624 Bytes 8 672 900 832 Bytes +1.2 MiB +0.014%
ydbd stripped size 471 804 168 Bytes 471 902 248 Bytes +95.8 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit b971ba4 into ydb-platform:main Aug 6, 2024
10 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3491-support-sql-for-resource-pool-classifiers branch August 6, 2024 10:19
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 15, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 4, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 9, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 11, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants