Skip to content

fix columns normalization for absent #7340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivanmorozov333
Copy link
Collaborator

sync different versions
additional checkers
improve tests

  • Improvement
  • Bugfix

sync different versions
additional checkers
improve tests
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 05:35:23 UTC Pre-commit check for 1a9d038 has started.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 05:35:24 UTC Pre-commit check for 1a9d038 has started.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 05:36:02 UTC Pre-commit check for 1a9d038 has started.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 06:19:40 UTC Pre-commit check for 1a9d038 has started.
2024-08-01 06:23:17 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 08:37:44 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9808 9748 0 18 27 15

🟢 2024-08-01 08:38:52 UTC Build successful.
🟡 2024-08-01 08:39:22 UTC ydbd size 5.4 GiB changed* by +159.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae8c7f9 merge: 1a9d038 diff diff %
ydbd size 5 841 311 496 Bytes 5 841 474 544 Bytes +159.2 KiB +0.003%
ydbd stripped size 1 463 911 024 Bytes 1 463 930 512 Bytes +19.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 06:21:54 UTC Pre-commit check for 1a9d038 has started.
2024-08-01 06:25:03 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 06:38:57 UTC Build successful.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 06:22:06 UTC Pre-commit check for 1a9d038 has started.
2024-08-01 06:25:06 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 08:26:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38542 33221 0 4 5306 11

2024-08-01 08:31:08 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-01 08:39:22 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 9 0 0 0 8

🟢 2024-08-01 08:42:36 UTC Build successful.
🟡 2024-08-01 08:43:13 UTC ydbd size 8.1 GiB changed* by +340.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae8c7f9 merge: 1a9d038 diff diff %
ydbd size 8 672 037 176 Bytes 8 672 385 632 Bytes +340.3 KiB +0.004%
ydbd stripped size 472 047 784 Bytes 472 050 728 Bytes +2.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review August 1, 2024 07:17
@ivanmorozov333 ivanmorozov333 merged commit b1c5908 into ydb-platform:main Aug 1, 2024
13 of 18 checks passed
@ivanmorozov333 ivanmorozov333 deleted the tests_and_fixes_columns_normalization branch August 1, 2024 08:55
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 14, 2024
 Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
	ydb/core/tx/columnshard/engines/changes/compaction/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 15, 2024
 Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
	ydb/core/tx/columnshard/engines/changes/compaction/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 15, 2024
 Conflicts:
	ydb/core/tx/columnshard/engines/changes/compaction/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
 Conflicts:
	ydb/core/tx/columnshard/engines/changes/compaction/abstract/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
 Conflicts:
	ydb/core/tx/columnshard/engines/changes/compaction/abstract/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
 Conflicts:
	ydb/core/tx/columnshard/engines/changes/compaction/abstract/merger.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Conflicts:
	ydb/core/tx/columnshard/engines/changes/compaction/abstract/merger.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants