Skip to content

fix empty column usage #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix empty column usage #7334

merged 1 commit into from
Aug 1, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

in normalization version schema's batch
add test

  • Bugfix

@ivanmorozov333
fix empty column usage
e9b8c12 
in actualizable version schema's batch
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 17:44:49 UTC Pre-commit check for af45022 has started.
⚪ 2024-07-31 17:48:19 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 19:47:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9619 9565 0 13 25 16

🟢 2024-07-31 19:48:58 UTC Build successful.
🟢 2024-07-31 19:49:26 UTC ydbd size 5.4 GiB changed* by -2.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3c1690d merge: af45022 diff diff %
ydbd size 5 840 648 056 Bytes 5 840 645 896 Bytes -2.1 KiB -0.000%
ydbd stripped size 1 463 787 056 Bytes 1 463 786 992 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 17:45:52 UTC Pre-commit check for af45022 has started.
⚪ 2024-07-31 17:48:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 17:53:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 17:47:23 UTC Pre-commit check for af45022 has started.
⚪ 2024-07-31 17:50:11 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 19:19:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13780 12430 0 2 1333 15

⚪ 2024-07-31 19:20:49 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-31 19:29:04 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 10 0 0 0 8

🟢 2024-07-31 19:30:12 UTC Build successful.
🟢 2024-07-31 19:30:44 UTC ydbd size 8.1 GiB changed* by -1.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3c1690d merge: af45022 diff diff %
ydbd size 8 671 064 544 Bytes 8 671 063 344 Bytes -1.2 KiB -0.000%
ydbd stripped size 472 011 944 Bytes 472 011 112 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review August 1, 2024 03:51
@ivanmorozov333 ivanmorozov333 merged commit ae8c7f9 into ydb-platform:main Aug 1, 2024
11 of 13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_new_columns_between_diff_versions branch August 1, 2024 03:53
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 8, 2024
Merged
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 15, 2024
@ivanmorozov333 @zverevgeny
fix empty column usage (ydb-platform#7334)
21930cf 
 Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
	ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Aug 15, 2024
@ivanmorozov333 @zverevgeny
fix empty column usage (ydb-platform#7334)
9c2d4f9 
 Conflicts:
	ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iddqdex iddqdex iddqdex approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @iddqdex