Skip to content

Implement LLVM for WideLastCombiner with spilling. #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

Tony-Romanov
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:23:40 UTC Pre-commit check for 2ca429f has started.
2024-07-31 11:26:22 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 11:30:51 UTC Build successful.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:23:42 UTC Pre-commit check for 2ca429f has started.
2024-07-31 11:26:53 UTC Check linux-x86_64-relwithdebinfo is running...
2024-07-31 11:52:39 UTC Check cancelled

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:23:51 UTC Pre-commit check for 2ca429f has started.
2024-07-31 11:26:29 UTC Check linux-x86_64-release-asan is running...
2024-07-31 11:52:33 UTC Check cancelled

@Tony-Romanov Tony-Romanov added the area/yql YQL query language issues label Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:54:11 UTC Pre-commit check for c3e8bed has started.
2024-07-31 11:57:03 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-31 14:01:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73436 59858 0 4 13561 13

2024-07-31 14:11:07 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-31 14:19:24 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 7 0 0 0 8

🟢 2024-07-31 14:26:34 UTC Build successful.
🟢 2024-07-31 14:27:10 UTC ydbd size 8.1 GiB changed* by +29.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e464b73 merge: c3e8bed diff diff %
ydbd size 8 678 737 472 Bytes 8 678 767 240 Bytes +29.1 KiB +0.000%
ydbd stripped size 471 916 032 Bytes 471 916 352 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 11:54:15 UTC Pre-commit check for c3e8bed has started.
2024-07-31 11:57:11 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 12:03:43 UTC Build successful.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 12:00:52 UTC Pre-commit check for c3e8bed has started.
2024-07-31 12:05:10 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 14:02:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12006 11937 0 15 36 18

🟢 2024-07-31 14:04:10 UTC Build successful.
🔴 2024-07-31 14:04:40 UTC ydbd size 5.5 GiB changed* by +275.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e464b73 merge: c3e8bed diff diff %
ydbd size 5 571 429 760 Bytes 5 860 531 048 Bytes +275.7 MiB +5.189%
ydbd stripped size 1 199 304 144 Bytes 1 467 602 160 Bytes +255.9 MiB +22.371%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov marked this pull request as ready for review July 31, 2024 14:31
@Tony-Romanov Tony-Romanov requested a review from a team as a code owner July 31, 2024 14:31
@Tony-Romanov Tony-Romanov enabled auto-merge (squash) July 31, 2024 14:31
@Tony-Romanov Tony-Romanov merged commit e1ecf37 into ydb-platform:main Jul 31, 2024
10 of 12 checks passed
@Tony-Romanov Tony-Romanov deleted the combiner_llvm branch July 31, 2024 17:38
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[[YQL]] Adapt WideLastCombinerWrapper to work with spilling in LLVM
2 participants