Skip to content

Fix trim duration (change microseconds to milliseconds) #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix trim duration (change microseconds to milliseconds) #7302

merged 1 commit into from
Aug 7, 2024

Conversation

@va-kuznecov
Copy link
Member

@va-kuznecov va-kuznecov commented Jul 31, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@va-kuznecov va-kuznecov requested a review from a team as a code owner July 31, 2024 11:10
@github-actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 11:11:58 UTC Pre-commit check for c740f8d has started.
⚪ 2024-07-31 11:14:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-31 11:37:38 UTC Build successful.
⚪ 2024-07-31 11:44:17 UTC Tests are running...
🔴 2024-07-31 13:54:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10360 9775 0 88 324 173

🟢 2024-07-31 13:55:30 UTC ydbd size 5.2 GiB changed* by +672 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 725b0df merge: c740f8d diff diff %
ydbd size 5 613 453 456 Bytes 5 613 454 128 Bytes +672 Bytes +0.000%
ydbd stripped size 1 210 296 840 Bytes 1 210 296 264 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
@github-actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 23:03:31 UTC Pre-commit check for 9d13873 has started.
⚪ 2024-08-01 23:06:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-01 23:12:35 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 23:18:15 UTC Pre-commit check for 9d13873 has started.
⚪ 2024-08-01 23:20:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-01 23:43:52 UTC Build successful.
⚪ 2024-08-01 23:44:07 UTC Tests are running...
🔴 2024-08-02 01:40:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10338 10281 0 14 27 16

🟢 2024-08-02 01:41:06 UTC ydbd size 5.5 GiB changed* by +592 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 900ca74 merge: 9d13873 diff diff %
ydbd size 5 904 548 296 Bytes 5 904 548 888 Bytes +592 Bytes +0.000%
ydbd stripped size 1 480 422 080 Bytes 1 480 421 440 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 23:57:11 UTC Pre-commit check for 9d13873 has started.
⚪ 2024-08-01 23:59:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 00:36:38 UTC Build successful.
⚪ 2024-08-02 00:36:54 UTC Tests are running...
🔴 2024-08-02 01:58:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14638 13314 0 2 1308 14

🟢 2024-08-02 01:59:29 UTC ydbd size 8.1 GiB changed* by +64 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 900ca74 merge: 9d13873 diff diff %
ydbd size 8 724 297 952 Bytes 8 724 298 016 Bytes +64 Bytes +0.000%
ydbd stripped size 476 950 792 Bytes 476 950 728 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov added the rebase-and-check Rebase PR with the current base branch and check label Aug 7, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 7, 2024
@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 10:51:09 UTC Pre-commit check for 0004200 has started.
⚪ 2024-08-07 10:53:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-07 11:17:14 UTC Build successful.
⚪ 2024-08-07 11:17:30 UTC Tests are running...
🔴 2024-08-07 13:44:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10322 10268 0 9 26 19

🟢 2024-08-07 13:45:04 UTC ydbd size 5.5 GiB changed* by +672 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 315fac0 merge: 0004200 diff diff %
ydbd size 5 903 314 568 Bytes 5 903 315 240 Bytes +672 Bytes +0.000%
ydbd stripped size 1 480 107 040 Bytes 1 480 106 464 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 10:52:13 UTC Pre-commit check for 0004200 has started.
⚪ 2024-08-07 10:54:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-07 10:59:37 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 10:52:48 UTC Pre-commit check for 0004200 has started.
⚪ 2024-08-07 10:55:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-07 11:32:52 UTC Build successful.
⚪ 2024-08-07 11:33:13 UTC Tests are running...
🔴 2024-08-07 12:57:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14624 13304 0 2 1306 12

🟢 2024-08-07 12:59:20 UTC ydbd size 8.1 GiB changed* by -16 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 315fac0 merge: 0004200 diff diff %
ydbd size 8 721 706 152 Bytes 8 721 706 136 Bytes -16 Bytes -0.000%
ydbd stripped size 476 877 672 Bytes 476 877 544 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov merged commit 0466744 into ydb-platform:stable-24-3 Aug 7, 2024
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
This was referenced Aug 16, 2024
Closed
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@siarheivesialou siarheivesialou mentioned this pull request Aug 28, 2024
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
This was referenced Oct 29, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@va-kuznecov va-kuznecov deleted the merge_trim_duration_24_3 branch July 18, 2025 10:56
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@va-kuznecov @fomichev3000 @maximyurchuk