Skip to content

speed up merging with correct pointers operation #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:12:25 UTC Pre-commit check for 29af54e has started.
2024-07-30 06:15:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 08:26:32 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9822 9248 0 80 322 172

🟢 2024-07-30 08:27:30 UTC Build successful.
🟢 2024-07-30 08:28:23 UTC ydbd size 5.2 GiB changed* by +17.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 75ab2b2 merge: 29af54e diff diff %
ydbd size 5 570 361 072 Bytes 5 570 379 424 Bytes +17.9 KiB +0.000%
ydbd stripped size 1 199 093 424 Bytes 1 199 097 136 Bytes +3.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:12:57 UTC Pre-commit check for 29af54e has started.
2024-07-30 06:15:51 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-30 06:27:58 UTC Build successful.

Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:13:02 UTC Pre-commit check for 29af54e has started.
2024-07-30 06:16:00 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-07-30 08:15:58 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38495 33210 0 0 5275 10

🟢 2024-07-30 08:19:37 UTC Build successful.
🟢 2024-07-30 08:20:18 UTC ydbd size 8.1 GiB changed* by +18.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 75ab2b2 merge: 29af54e diff diff %
ydbd size 8 677 212 552 Bytes 8 677 231 032 Bytes +18.0 KiB +0.000%
ydbd stripped size 471 842 208 Bytes 471 843 488 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review July 30, 2024 10:58
@ivanmorozov333 ivanmorozov333 merged commit 49a8f16 into ydb-platform:main Jul 30, 2024
11 of 13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_merging branch July 30, 2024 10:58
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 12, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants