Skip to content

Fix LWTrace leaking HTTP request string to HTML page (#7011) #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

the-ancient-1
Copy link
Member

Changelog entry

Replace HTTP control characters with alternative ones while displaying exceptions.

Changelog category

  • Bugfix

Additional information

...

@the-ancient-1 the-ancient-1 changed the title Fix LWTrace leaking HTTP request string to HTML page Fix LWTrace leaking HTTP request string to HTML page (#7011) Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 17:33:28 UTC Pre-commit check for 640d925 has started.
2024-07-23 17:35:03 UTC Check cancelled

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 17:34:16 UTC Pre-commit check for 640d925 has started.
2024-07-23 17:35:03 UTC Check cancelled

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 17:36:28 UTC Pre-commit check for b73679d has started.
2024-07-23 17:39:16 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 19:38:51 UTC Build successful.
🔴 2024-07-23 19:42:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10838 10243 0 95 328 172

🟡 2024-07-23 19:43:30 UTC ydbd size 5.2 GiB changed* by +218.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e30c4cd merge: b73679d diff diff %
ydbd size 5 555 934 616 Bytes 5 556 157 856 Bytes +218.0 KiB +0.004%
ydbd stripped size 1 196 755 632 Bytes 1 196 797 840 Bytes +41.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 17:36:58 UTC Pre-commit check for b73679d has started.
2024-07-23 17:40:31 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 17:45:57 UTC Build successful.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 17:39:11 UTC Pre-commit check for b73679d has started.
2024-07-23 17:41:55 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-23 19:38:51 UTC Build successful.
🔴 2024-07-23 19:43:27 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39510 34219 0 4 5275 12

🟡 2024-07-23 19:44:09 UTC ydbd size 8.1 GiB changed* by +236.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e30c4cd merge: b73679d diff diff %
ydbd size 8 652 445 792 Bytes 8 652 687 648 Bytes +236.2 KiB +0.003%
ydbd stripped size 471 045 664 Bytes 471 059 936 Bytes +13.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@the-ancient-1 the-ancient-1 merged commit 054742d into ydb-platform:main Jul 23, 2024
8 of 12 checks passed
@the-ancient-1 the-ancient-1 deleted the fix_lwtrace_html branch July 23, 2024 19:54
the-ancient-1 added a commit to the-ancient-1/ydb that referenced this pull request Jul 23, 2024
the-ancient-1 added a commit to the-ancient-1/ydb that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants