Skip to content

CS improvements #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 28, 2024
Merged

CS improvements #7013

merged 26 commits into from
Jul 28, 2024

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Jul 23, 2024 •
edited
Loading

Integrate perf and bug fixes in CS from main

@ivanmorozov333 @zverevgeny
fix signal value (ydb-platform#6314)
14a86a0
@ivanmorozov333 @zverevgeny
fix test in asan (nullptr possible in original data) (ydb-platform#6369)
d90075c
@ivanmorozov333 @zverevgeny
serialize special keys in separated thread (ydb-platform#6324)
a566ec4
@ivanmorozov333 @zverevgeny
prevent overlimit for ui32 in genstep (ydb-platform#6365)
2b59a44
@ivanmorozov333 @zverevgeny
reduce logging (ydb-platform#6343)
856abe8
@ivanmorozov333 @zverevgeny
fix huge blobs volume for start mode withno barrier moving (ydb-platf…
cf97903 
…orm#6366)
@ivanmorozov333 @zverevgeny
corrections for gc tasks construction (ydb-platform#6376)
4fe73dd
@ivanmorozov333 @zverevgeny
remove hard freeing from tablet (ydb-platform#6377)
f56e028
@ivanmorozov333 @zverevgeny
correct insert table cleaning (ydb-platform#6379)
e3e040f
@ivanmorozov333 @zverevgeny
small transfer meta processing correction (ydb-platform#6386)
5015970
@ivanmorozov333 @zverevgeny
fix resharding tests implementation (ydb-platform#6388)
bb0fd52
@ivanmorozov333 @zverevgeny
remove portions constructor hard freeing from tablet (ydb-platform#6389)
eee37d2
@ivanmorozov333 @zverevgeny
reduce logging volume (ydb-platform#6418)
7c8988f
@ivanmorozov333 @zverevgeny
fix disk writing limiter (ydb-platform#6452)
3db3754
@ivanmorozov333 @zverevgeny
conveyor logging and remove ownerId - internal processes only (ydb-pl…
5d5b545 
…atform#6442)
@ivanmorozov333 @zverevgeny
fix splitting to prevent empty batches (ydb-platform#6632)
40b8f3f
@ivanmorozov333 @zverevgeny
fix throw flag usage (ydb-platform#6633)
5ab12a0
@ivanmorozov333 @zverevgeny
fix resharding tests on race gc with sharing (ydb-platform#6654)
b373aff
@ivanmorozov333 @zverevgeny
Correct index construction (ydb-platform#6500)
f2e678c
@ivanmorozov333 @zverevgeny
Limit requested memory (ydb-platform#6698)
9727cbb
@ivanmorozov333 @zverevgeny
rename ExecuteOnProgress -> ProgressOnExecute (ydb-platform#6739)
d96d33d
@ivanmorozov333 @zverevgeny
add test for GC usage on insert/delete (ydb-platform#6726)
d8e0085
@ivanmorozov333 @zverevgeny
improve scan read for aggregations (use commands in step before group… (
9be9dea 
ydb-platform#6756)
@ivanmorozov333 @zverevgeny
fix index actualization (ydb-platform#6793)
1b8c280
@zverevgeny zverevgeny changed the title Olap to 24 3 CS improvements Jul 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 17:33:08 UTC Pre-commit check for d86bb6b has started.
⚪ 2024-07-23 17:36:05 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-23 17:52:02 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 17:33:39 UTC Pre-commit check for d86bb6b has started.
⚪ 2024-07-23 17:36:32 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-23 17:43:01 UTC Build failed. see the build logs.
🔴 2024-07-23 17:43:02 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 17:34:38 UTC Pre-commit check for d86bb6b has started.
⚪ 2024-07-23 17:37:35 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-23 17:52:52 UTC Build failed. see the build logs.
🔴 2024-07-23 17:52:53 UTC Tests run skipped.

maximyurchuk
maximyurchuk requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Прошу

  • добавить описание в ПР
  • добавить ссылку на #6885 (это же чинит текущий ПР?)
  • заполнить #7013

@zverevgeny zverevgeny linked an issue Jul 25, 2024 that may be closed by this pull request
CS fails on verify in 24.3 #6885
Closed
@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Jul 27, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 12:42:47 UTC Pre-commit check for a620ac0 has started.
⚪ 2024-07-27 12:45:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-27 13:35:44 UTC Build successful.
⚪ 2024-07-27 13:36:04 UTC Tests are running...
🔴 2024-07-27 15:54:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15142 14527 0 97 347 171

🟢 2024-07-27 15:55:08 UTC ydbd size 5.2 GiB changed* by -5.5 MiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 90805a4 merge: a620ac0 diff diff %
ydbd size 5 618 026 640 Bytes 5 612 291 024 Bytes -5.5 MiB -0.102%
ydbd stripped size 1 211 593 864 Bytes 1 210 289 480 Bytes -1.2 MiB -0.108%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 12:45:18 UTC Pre-commit check for a620ac0 has started.
⚪ 2024-07-27 12:48:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-27 13:31:12 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 12:46:59 UTC Pre-commit check for a620ac0 has started.
⚪ 2024-07-27 12:49:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-27 13:51:23 UTC Build successful.
⚪ 2024-07-27 13:51:41 UTC Tests are running...
🔴 2024-07-27 15:55:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76188 62747 0 2 13427 12

🟢 2024-07-27 15:56:34 UTC ydbd size 8.1 GiB changed* by -7.2 MiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 90805a4 merge: a620ac0 diff diff %
ydbd size 8 729 108 536 Bytes 8 721 536 512 Bytes -7.2 MiB -0.087%
ydbd stripped size 477 365 064 Bytes 476 948 488 Bytes -406.8 KiB -0.087%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 17:42:58 UTC Pre-commit check for d74c249 has started.
⚪ 2024-07-27 17:45:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-27 17:52:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 17:43:51 UTC Pre-commit check for d74c249 has started.
⚪ 2024-07-27 17:46:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-27 18:12:40 UTC Build successful.
⚪ 2024-07-27 18:12:57 UTC Tests are running...
🔴 2024-07-27 20:30:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15142 14519 0 95 350 178

🟢 2024-07-27 20:31:26 UTC ydbd size 5.2 GiB changed* by -5.5 MiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 90223b3 merge: d74c249 diff diff %
ydbd size 5 618 026 336 Bytes 5 612 291 024 Bytes -5.5 MiB -0.102%
ydbd stripped size 1 211 593 864 Bytes 1 210 289 480 Bytes -1.2 MiB -0.108%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

⚪ 2024-07-27 17:45:35 UTC Pre-commit check for d74c249 has started.
⚪ 2024-07-27 17:48:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-27 18:29:14 UTC Build successful.
⚪ 2024-07-27 18:29:30 UTC Tests are running...
🔴 2024-07-27 20:40:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76189 62748 0 3 13425 13

🟢 2024-07-27 20:40:50 UTC ydbd size 8.1 GiB changed* by -7.2 MiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 90223b3 merge: d74c249 diff diff %
ydbd size 8 729 108 424 Bytes 8 721 536 512 Bytes -7.2 MiB -0.087%
ydbd stripped size 477 365 064 Bytes 476 948 488 Bytes -406.8 KiB -0.087%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny requested a review from maximyurchuk July 27, 2024 18:08
@zverevgeny zverevgeny marked this pull request as ready for review July 28, 2024 10:11
@zverevgeny zverevgeny requested a review from a team as a code owner July 28, 2024 10:11
@maximyurchuk maximyurchuk removed their request for review July 28, 2024 10:13
@zverevgeny zverevgeny merged commit a196e19 into ydb-platform:stable-24-3 Jul 28, 2024
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
This was referenced Aug 16, 2024
Closed
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@siarheivesialou siarheivesialou mentioned this pull request Aug 28, 2024
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
This was referenced Oct 29, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS fails on verify in 24.3
4 participants
@zverevgeny @fomichev3000 @maximyurchuk @ivanmorozov333