Skip to content

SQL command ANALYZE #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 5, 2024
Merged

SQL command ANALYZE #6996

merged 12 commits into from
Aug 5, 2024

Conversation

pashandor789
Copy link
Collaborator

@pashandor789 pashandor789 commented Jul 23, 2024 •
edited
Loading

Changelog category

  • New feature

@pashandor789 pashandor789 requested a review from a team as a code owner July 23, 2024 12:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 12:51:32 UTC Pre-commit check for ad343dd has started.
⚪ 2024-07-23 12:55:03 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 13:32:06 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 12:51:47 UTC Pre-commit check for ad343dd has started.
⚪ 2024-07-23 12:55:01 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-23 15:30:47 UTC Build successful.
🔴 2024-07-23 15:38:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74236 60669 0 5 13550 12

🟡 2024-07-23 15:39:43 UTC ydbd size 8.1 GiB changed* by +1.5 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d3f1c82 merge: ad343dd diff diff %
ydbd size 8 652 510 112 Bytes 8 654 057 872 Bytes +1.5 MiB +0.018%
ydbd stripped size 471 041 952 Bytes 471 105 856 Bytes +62.4 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 12:52:22 UTC Pre-commit check for ad343dd has started.
⚪ 2024-07-23 12:55:26 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 15:30:58 UTC Build successful.
🔴 2024-07-23 15:34:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12848 12242 0 95 335 176

🟡 2024-07-23 15:35:19 UTC ydbd size 5.2 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d3f1c82 merge: ad343dd diff diff %
ydbd size 5 555 985 832 Bytes 5 557 181 560 Bytes +1.1 MiB +0.022%
ydbd stripped size 1 196 733 360 Bytes 1 197 053 488 Bytes +312.6 KiB +0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

spuchin
spuchin reviewed Jul 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 17:39:59 UTC Pre-commit check for 37d5bc8 has started.
⚪ 2024-07-25 17:43:07 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-25 18:30:45 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 17:40:05 UTC Pre-commit check for 37d5bc8 has started.
⚪ 2024-07-25 17:43:24 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 18:25:41 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 17:41:29 UTC Pre-commit check for 37d5bc8 has started.
⚪ 2024-07-25 17:44:25 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-25 18:30:49 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 18:32:37 UTC Pre-commit check for 17702ee has started.
⚪ 2024-07-25 18:35:57 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 20:52:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74271 60699 0 12 13548 12

⚪ 2024-07-25 21:00:32 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 21:08:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 13 0 2 0 9

⚪ 2024-07-25 21:15:06 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-25 21:22:55 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 2 0 2 0 8

🟢 2024-07-25 21:29:44 UTC Build successful.
🟡 2024-07-25 21:30:23 UTC ydbd size 8.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 34b6297 merge: 17702ee diff diff %
ydbd size 8 667 429 864 Bytes 8 669 466 720 Bytes +1.9 MiB +0.024%
ydbd stripped size 471 525 696 Bytes 471 589 216 Bytes +62.0 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 18:33:33 UTC Pre-commit check for 17702ee has started.
⚪ 2024-07-25 18:36:44 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 20:58:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12878 12275 0 93 338 172

🟢 2024-07-25 20:59:20 UTC Build successful.
🟡 2024-07-25 21:00:12 UTC ydbd size 5.2 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 34b6297 merge: 17702ee diff diff %
ydbd size 5 564 663 224 Bytes 5 566 029 088 Bytes +1.3 MiB +0.025%
ydbd stripped size 1 198 266 832 Bytes 1 198 580 496 Bytes +306.3 KiB +0.026%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 18:34:14 UTC Pre-commit check for 17702ee has started.
⚪ 2024-07-25 18:37:23 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 18:43:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:06:55 UTC Pre-commit check for 71702db has started.
⚪ 2024-07-28 18:10:17 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-28 18:20:23 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:07:15 UTC Pre-commit check for 71702db has started.
⚪ 2024-07-28 18:10:39 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-28 18:19:58 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:07:41 UTC Pre-commit check for 71702db has started.
⚪ 2024-07-28 18:11:01 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-28 18:18:35 UTC Build failed. see the logs.

@pashandor789 pashandor789 force-pushed the analyze branch 2 times, most recently from e19cc0b to 002f808 Compare July 29, 2024 02:44
@azevaykin azevaykin changed the title [ANALYZE] Added. SQL command ANALYZE Jul 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 14:07:19 UTC Pre-commit check for b44da47 has started.
⚪ 2024-07-29 14:10:57 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-29 16:43:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12845 12255 0 87 333 170

🟢 2024-07-29 16:45:18 UTC Build successful.
🟡 2024-07-29 16:46:11 UTC ydbd size 5.2 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 13b5991 merge: b44da47 diff diff %
ydbd size 5 569 940 648 Bytes 5 571 903 456 Bytes +1.9 MiB +0.035%
ydbd stripped size 1 199 045 136 Bytes 1 199 504 976 Bytes +449.1 KiB +0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 14:08:25 UTC Pre-commit check for b44da47 has started.
⚪ 2024-07-29 14:11:46 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-29 14:52:16 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 14:08:41 UTC Pre-commit check for b44da47 has started.
⚪ 2024-07-29 14:11:54 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-29 16:45:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74238 60675 0 5 13547 11

⚪ 2024-07-29 16:53:04 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-29 17:01:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 4 0 2 0 8

⚪ 2024-07-29 17:08:34 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-29 17:16:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11 (only retried tests) 1 0 2 0 8

🟢 2024-07-29 17:23:43 UTC Build successful.
🔴 2024-07-29 17:24:20 UTC ydbd size 8.1 GiB changed* by +2.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 13b5991 merge: b44da47 diff diff %
ydbd size 8 676 409 400 Bytes 8 679 396 056 Bytes +2.8 MiB +0.034%
ydbd stripped size 471 818 208 Bytes 471 955 744 Bytes +134.3 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

azevaykin
azevaykin reviewed Jul 30, 2024
View reviewed changes
ydb/core/kqp/gateway/actors/analyze_actor.cpp
Become(&TAnalyzeActor::StateWork);
}

void TAnalyzeActor::Handle(NStat::TEvStatistics::TEvAnalyzeResponse::TPtr& ev, const TActorContext& ctx) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужен модульный тест, который создаст таблицу, вставит данных, отправит SQL команду ANALYZE и дождется её успешного завершения.

Разные тесты для строковых и колоночных таблиц.
Разные тесты для нескольких таблиц в одном запросе ANALYZE.
Разные тесты для нескольких колонок в одном запросе ANALYZE.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Увидел только один модульный тест, нужно больше.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 10:20:36 UTC Pre-commit check for 3ee2109 has started.
⚪ 2024-07-30 10:23:32 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 12:52:57 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12854 12264 0 86 329 175

🟢 2024-07-30 12:54:11 UTC Build successful.
🟡 2024-07-30 12:55:07 UTC ydbd size 5.2 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0138b90 merge: 3ee2109 diff diff %
ydbd size 5 570 781 208 Bytes 5 572 740 264 Bytes +1.9 MiB +0.035%
ydbd stripped size 1 199 150 352 Bytes 1 199 606 160 Bytes +445.1 KiB +0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 10:31:49 UTC Pre-commit check for ab02bdc has started.
⚪ 2024-08-05 10:35:00 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-05 13:08:41 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12852 12796 0 12 31 13

🟢 2024-08-05 13:10:10 UTC Build successful.
🔴 2024-08-05 13:10:43 UTC ydbd size 5.4 GiB changed* by +2.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: a1f1ecc merge: ab02bdc diff diff %
ydbd size 5 825 869 880 Bytes 5 828 034 136 Bytes +2.1 MiB +0.037%
ydbd stripped size 1 463 178 928 Bytes 1 463 729 584 Bytes +537.8 KiB +0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 10:32:45 UTC Pre-commit check for ab02bdc has started.
⚪ 2024-08-05 10:35:56 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-05 13:17:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 13:18:36 UTC Pre-commit check for 2a8cc18 has started.
⚪ 2024-08-05 13:22:24 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-05 14:39:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 13:20:19 UTC Pre-commit check for 2a8cc18 has started.
⚪ 2024-08-05 13:23:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 13:31:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 13:21:06 UTC Pre-commit check for 2a8cc18 has started.
⚪ 2024-08-05 13:24:19 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-05 14:39:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 14:43:21 UTC Pre-commit check for cf9ecf9 has started.
⚪ 2024-08-05 14:46:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-05 17:21:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12860 12801 0 11 31 17

🟢 2024-08-05 17:23:00 UTC Build successful.
🟡 2024-08-05 17:23:34 UTC ydbd size 5.4 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e4c34ae merge: cf9ecf9 diff diff %
ydbd size 5 828 208 184 Bytes 5 830 292 440 Bytes +2.0 MiB +0.036%
ydbd stripped size 1 463 788 400 Bytes 1 464 319 152 Bytes +518.3 KiB +0.036%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 14:43:27 UTC Pre-commit check for cf9ecf9 has started.
⚪ 2024-08-05 14:47:17 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-05 15:27:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 14:43:43 UTC Pre-commit check for cf9ecf9 has started.
⚪ 2024-08-05 14:46:56 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-05 17:21:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74372 60754 0 6 13594 18

⚪ 2024-08-05 17:30:44 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-05 17:39:32 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32 (only retried tests) 22 0 0 1 9

🟢 2024-08-05 17:46:45 UTC Build successful.
🔴 2024-08-05 17:47:19 UTC ydbd size 8.1 GiB changed* by +2.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e4c34ae merge: cf9ecf9 diff diff %
ydbd size 8 668 415 856 Bytes 8 671 300 784 Bytes +2.8 MiB +0.033%
ydbd stripped size 471 630 824 Bytes 471 754 504 Bytes +120.8 KiB +0.026%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pashandor789 pashandor789 enabled auto-merge (squash) August 5, 2024 17:58
@pashandor789 pashandor789 dismissed nepal’s stale review August 5, 2024 18:00

Уже выполнил

@pashandor789 pashandor789 merged commit 59654e9 into ydb-platform:main Aug 5, 2024
10 of 12 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 8, 2024
Merged
Merged
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Aug 30, 2024
@pashandor789 @azevaykin
SQL command ANALYZE (ydb-platform#6996)
664ee13
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Sep 3, 2024
@pashandor789 @azevaykin
SQL command ANALYZE (ydb-platform#6996)
f267d71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik left review comments

@azevaykin azevaykin azevaykin left review comments

@vitstn vitstn vitstn approved these changes

@nepal nepal nepal left review comments

@spuchin spuchin spuchin left review comments

@alexnick88 alexnick88 Awaiting requested review from alexnick88 alexnick88 was automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pashandor789 @nepal @spuchin @vitstn @uzhastik @azevaykin