Skip to content

Allow to describe index tables as common tables #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 22, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL requested review from ijon and spuchin July 22, 2024 15:21
@CyberROFL CyberROFL self-assigned this Jul 22, 2024
@CyberROFL CyberROFL marked this pull request as ready for review July 22, 2024 15:21
@CyberROFL CyberROFL changed the title Allow to describe index tables Allow to describe index tables as common tables Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 15:45:39 UTC Pre-commit check for a6ed454 has started.
2024-07-22 15:48:11 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 15:51:59 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 15:45:54 UTC Pre-commit check for a6ed454 has started.
2024-07-22 15:49:06 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-22 17:48:44 UTC Test run completed, no test results found for commit aa3196d.
2024-07-22 17:48:53 UTC Check cancelled

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 15:47:28 UTC Pre-commit check for a6ed454 has started.
2024-07-22 15:50:10 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 17:19:21 UTC Build successful.
🔴 2024-07-22 17:21:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13939 12603 0 12 1311 13

🟡 2024-07-22 17:22:02 UTC ydbd size 8.1 GiB changed* by +203.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 427c5e6 merge: a6ed454 diff diff %
ydbd size 8 659 284 416 Bytes 8 659 493 192 Bytes +203.9 KiB +0.002%
ydbd stripped size 471 148 704 Bytes 471 152 160 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from Enjection July 22, 2024 16:19
Enjection
Enjection previously approved these changes Jul 22, 2024
Enjection
Enjection previously approved these changes Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 17:52:37 UTC Pre-commit check for a5b84bc has started.
2024-07-22 17:55:16 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 18:03:44 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 17:52:48 UTC Pre-commit check for a5b84bc has started.
2024-07-22 17:55:28 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 19:22:29 UTC Build successful.
🔴 2024-07-22 19:25:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13942 12611 0 10 1310 11

🟡 2024-07-22 19:25:45 UTC ydbd size 8.1 GiB changed* by +204.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: db92b74 merge: a5b84bc diff diff %
ydbd size 8 648 548 016 Bytes 8 648 756 968 Bytes +204.1 KiB +0.002%
ydbd stripped size 470 825 728 Bytes 470 829 376 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 17:52:52 UTC Pre-commit check for a5b84bc has started.
2024-07-22 17:55:40 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-22 19:53:04 UTC Test run completed, no test results found for commit c8de6f0.
2024-07-22 19:53:20 UTC Check cancelled

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 19:57:11 UTC Pre-commit check for b91506f has started.
2024-07-22 20:00:01 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 20:05:57 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 19:57:23 UTC Pre-commit check for b91506f has started.
2024-07-22 20:00:07 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 21:30:37 UTC Build successful.
🔴 2024-07-22 21:32:35 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13960 12607 0 5 1327 21

🟡 2024-07-22 21:33:18 UTC ydbd size 8.1 GiB changed* by +203.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eba228e merge: b91506f diff diff %
ydbd size 8 650 062 936 Bytes 8 650 271 192 Bytes +203.4 KiB +0.002%
ydbd stripped size 470 897 152 Bytes 470 900 608 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 19:57:25 UTC Pre-commit check for b91506f has started.
2024-07-22 20:00:08 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-22 22:11:07 UTC Build successful.
🔴 2024-07-22 22:14:44 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9663 9065 0 94 330 174

🟡 2024-07-22 22:15:41 UTC ydbd size 5.2 GiB changed* by +156.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eba228e merge: b91506f diff diff %
ydbd size 5 554 156 288 Bytes 5 554 316 744 Bytes +156.7 KiB +0.003%
ydbd stripped size 1 196 322 288 Bytes 1 196 335 664 Bytes +13.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dcherednik
dcherednik previously approved these changes Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 10:59:20 UTC Pre-commit check for 4d680b9 has started.
2024-07-23 11:02:05 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-23 11:42:16 UTC Test run completed, no test results found for commit eb6300c.
2024-07-23 11:42:39 UTC Check cancelled

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:01:36 UTC Pre-commit check for 4d680b9 has started.
2024-07-23 11:04:26 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 11:09:59 UTC Build successful.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:02:36 UTC Pre-commit check for 4d680b9 has started.
2024-07-23 11:05:16 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-23 11:42:20 UTC Test run completed, no test results found for commit eb6300c.
2024-07-23 11:43:02 UTC Check cancelled

@CyberROFL CyberROFL force-pushed the describe-index-table branch from eb6300c to 5e2ae16 Compare July 23, 2024 11:41
@CyberROFL CyberROFL force-pushed the describe-index-table branch from 5e2ae16 to 5a401c9 Compare July 23, 2024 11:42
Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:45:20 UTC Pre-commit check for dbb09b7 has started.
2024-07-23 11:48:31 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 13:52:26 UTC Build successful.
🔴 2024-07-23 13:55:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9679 9083 0 97 325 174

🟡 2024-07-23 13:56:05 UTC ydbd size 5.2 GiB changed* by +156.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c12733d merge: dbb09b7 diff diff %
ydbd size 5 556 014 808 Bytes 5 556 175 312 Bytes +156.7 KiB +0.003%
ydbd stripped size 1 196 745 104 Bytes 1 196 758 352 Bytes +12.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:47:18 UTC Pre-commit check for dbb09b7 has started.
2024-07-23 11:50:02 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-23 13:21:46 UTC Build successful.
🔴 2024-07-23 13:23:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13978 12636 0 2 1328 12

🟡 2024-07-23 13:24:16 UTC ydbd size 8.1 GiB changed* by +203.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c12733d merge: dbb09b7 diff diff %
ydbd size 8 652 507 304 Bytes 8 652 715 464 Bytes +203.3 KiB +0.002%
ydbd stripped size 471 044 192 Bytes 471 047 648 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:47:22 UTC Pre-commit check for dbb09b7 has started.
2024-07-23 11:50:02 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 12:04:50 UTC Build successful.

@Enjection Enjection self-requested a review July 23, 2024 12:15
@CyberROFL CyberROFL enabled auto-merge (squash) July 23, 2024 13:42
@CyberROFL CyberROFL merged commit 4cdd4a7 into ydb-platform:main Jul 23, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the describe-index-table branch July 23, 2024 13:57
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants