Skip to content

fix for dead nodes always passing filter #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Jul 22, 2024

Changelog entry

fix for dead nodes always passing filter
fixes #6608

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat self-assigned this Jul 22, 2024
@adameat adameat requested a review from StekPerepolnen July 22, 2024 05:12
@adameat adameat enabled auto-merge (squash) July 22, 2024 05:12
Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 05:15:17 UTC Pre-commit check for 43b9352 has started.
2024-07-22 05:18:00 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-22 07:24:16 UTC Build successful.
🔴 2024-07-22 07:25:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9461 8860 0 104 324 173

🟢 2024-07-22 07:26:26 UTC ydbd size 5.2 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5e95651 merge: 43b9352 diff diff %
ydbd size 5 556 133 632 Bytes 5 556 135 104 Bytes +1.4 KiB +0.000%
ydbd stripped size 1 197 007 984 Bytes 1 197 008 240 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 05:15:18 UTC Pre-commit check for 43b9352 has started.
2024-07-22 05:17:57 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 05:24:28 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 05:15:33 UTC Pre-commit check for 43b9352 has started.
2024-07-22 05:18:18 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 06:48:35 UTC Build successful.
🔴 2024-07-22 06:50:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13589 12254 0 2 1315 18

🟡 2024-07-22 06:51:13 UTC ydbd size 8.1 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1c15550 merge: 43b9352 diff diff %
ydbd size 8 656 109 112 Bytes 8 657 166 384 Bytes +1.0 MiB +0.012%
ydbd stripped size 471 115 872 Bytes 471 140 640 Bytes +24.2 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit c921a59 into ydb-platform:main Jul 22, 2024
9 of 13 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Aug 7, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
@adameat adameat deleted the fix-nodes branch November 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewer/nodes always return unavailable nodes
2 participants