YQ-2670 switch generic tests to docker compose #691
Conversation
| Sleep(TDuration::Seconds(5)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Я бы сказал, что для PG тоже нужны ретраи. Во всяком, случае, я наблюдаю такую же проблему в своих тестах на generic provider
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit 9db6d12.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 9db6d12.
|
| } | ||
|
|
||
| ui32 GetChPort() { | ||
| return FromString<ui32>(GetEnv("RECIPE_CLICKHOUSE_NATIVE_PORT", "1234")); | ||
| return 19000; |
There was a problem hiding this comment.
Why the port is hardcoded? What will happen if several tests that use recipe will be started at the same time?
There was a problem hiding this comment.
What will happen if several tests that use recipe will be started at the same time?
We intentionally disable local parallel runs (avoid FORK_SUBTESTS and so on) of tests based on docker-compose recipe because they look broken in ya. For more details, see link in TG channel :)
ydb/core/kqp/ut/federated_query/generic/ch_recipe_ut_helpers.cpp
Outdated
Show resolved
Hide resolved
ydb/core/kqp/ut/federated_query/generic/ch_recipe_ut_helpers.cpp
Outdated
Show resolved
Hide resolved
| return pqxx::connection{connectionString}; | ||
| } catch (const pqxx::broken_connection& e) { | ||
| Cerr << "Attempt " << attempt << ": " << e.what() << Endl; | ||
| Sleep(TDuration::Seconds(5)); |
There was a problem hiding this comment.
The same issues as for clickhouse
| @@ -0,0 +1,25 @@ | |||
| version: '3.4' | |||
There was a problem hiding this comment.
We already have a configured file here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/providers/generic/connector/tests/docker-compose.yml
Let's make a reusable recipe from it and use it in both places
The example of making a recipe: https://github.com/ydb-platform/ydb/tree/main/ydb/tests/tools/s3_recipe
There was a problem hiding this comment.
We already have a configured file here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/providers/generic/connector/tests/docker-compose.yml
Let's make a reusable recipe from it and use it in both places
This docker-compose.yml will highly likely split into several parts soon (integration tests will be separated into different directories as well). I'm afraid this will make it impossible to reuse this file in both kinds of tests.
* Switched KQP generic provider tests to docker-compose * Fixed retries
No description provided.